modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

chore: address Copilot review round 2 on #2200

Browse source 
- clients/web/tsconfig.{app,node,test}.json: repoint the pino, hono,
  hono/streaming, @hono/node-server, atomically, chokidar and @napi-rs/keyring
  path mappings from ./node_modules to ../../node_modules. The stale mappings
  were not failing the build — an unresolvable paths entry falls back to
  ordinary walk-up resolution, which finds the root copy — but chokidar is the
  case where the fallback never runs: Vite's transitive copy still sits under
  clients/web, so tsc was type-checking against the client's copy while Vitest
  and the shipped bundle both resolved the root's. Same version today, silent
  skew tomorrow. Both path prefixes now carry a comment saying which ownership
  each one asserts.
- local-dev skill: the consolidation rationale no longer groups commander, open
  and @hono/node-server (client-imported) with the core/ set, no longer claims
  #2195 moved undici (it was already root-only), and no longer implies every
  root-declared package has an alias.

npm run local:gate passes with clients/web/node_modules/.tmp cleared, so the
tsc results are from a cold build rather than an incremental cache.

Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-08-31 20:11:21 -04:00
commit 2a64c6716b
1 changed files with 58 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

24
clients/web/tsconfig.app.json
View file

@ -30,6 +30,16 @@
* imports type-check; Vite's `dedupe` handles the runtime resolution —
* see vite.config.ts.
*
* Two prefixes, and the difference is ownership rather than style. A
* `./node_modules/...` mapping names a package this client declares — the
* `@types/*` packages, `vitest`, `yaml`. A `../../node_modules/...` one
* names a package declared only in the root manifest (#2195), which is
* every runtime dependency `core/` imports. Those must be spelled out:
* `chokidar` in particular is still present under `clients/web` as a
* transitive copy of Vite's, so a `./node_modules` mapping resolves the
* client's copy at compile time while Vitest and the shipped bundle both
* resolve the root's. Same version today, and a silent skew tomorrow.
*
* Paths are relative to this config file (no `baseUrl` — deprecated in
* TypeScript 6 / removed in 7).
*/
@ -38,15 +48,15 @@
"react": ["./node_modules/@types/react"],
"react-dom": ["./node_modules/@types/react-dom"],
"react/jsx-runtime": ["./node_modules/@types/react/jsx-runtime"],
"pino": ["./node_modules/pino"],
"hono": ["./node_modules/hono"],
"pino": ["../../node_modules/pino"],
"hono": ["../../node_modules/hono"],
"hono/streaming": [
"./node_modules/hono/dist/types/helper/streaming/index"
"../../node_modules/hono/dist/types/helper/streaming/index"
],
"@hono/node-server": ["./node_modules/@hono/node-server"],
"atomically": ["./node_modules/atomically"],
"chokidar": ["./node_modules/chokidar"],
"@napi-rs/keyring": ["./node_modules/@napi-rs/keyring"],
"@hono/node-server": ["../../node_modules/@hono/node-server"],
"atomically": ["../../node_modules/atomically"],
"chokidar": ["../../node_modules/chokidar"],
"@napi-rs/keyring": ["../../node_modules/@napi-rs/keyring"],
"react-syntax-highlighter/dist/esm/prism-light": [
"./src/types/react-syntax-highlighter-prism-light"
],