chore: close quality-gate coverage gaps (#1689) (#1766)
Some checks failed
Run install, format, lint, build, and test on every push / build (push) Has been cancelled
Run install, format, lint, build, and test on every push / publish (push) Has been cancelled
Run install, format, lint, build, and test on every push / publish-github-container-registry (push) Has been cancelled
Some checks failed
Run install, format, lint, build, and test on every push / build (push) Has been cancelled
Run install, format, lint, build, and test on every push / publish (push) Has been cancelled
Run install, format, lint, build, and test on every push / publish-github-container-registry (push) Has been cancelled
Closes #1689. Typecheck cli/tui src, add a core/ format+lint gate, and gate core/json + core/client coverage. See PR #1766 for the full review history.
This commit is contained in:
parent
d76c4d5379
commit
373f346e5f
2 changed files with 2210 additions and 467 deletions
|
|
@ -11,6 +11,7 @@ import type {
|
|||
MCPServerConfig,
|
||||
ServerState,
|
||||
} from "@inspector/core/mcp/index.js";
|
||||
import { headersToServerSettings } from "@inspector/core/mcp/node/servers.js";
|
||||
import { InfoTab } from "../src/components/InfoTab.js";
|
||||
|
||||
// Ink processes stdin keypresses asynchronously — await this after stdin.write
|
||||
|
|
@ -127,14 +128,11 @@ describe("InfoTab", () => {
|
|||
type: "sse",
|
||||
url: "https://example.com/sse",
|
||||
};
|
||||
const withHeaders = {
|
||||
...config,
|
||||
headers: { Authorization: "Bearer x" },
|
||||
} as unknown as MCPServerConfig;
|
||||
const { lastFrame } = render(
|
||||
<InfoTab
|
||||
serverName="my-server"
|
||||
serverConfig={withHeaders}
|
||||
serverConfig={config}
|
||||
serverSettings={headersToServerSettings({ Authorization: "Bearer x" })}
|
||||
serverState={baseState}
|
||||
width={80}
|
||||
height={20}
|
||||
|
|
@ -167,15 +165,15 @@ describe("InfoTab", () => {
|
|||
});
|
||||
|
||||
it("renders a streamable-http config with headers", () => {
|
||||
const config = {
|
||||
const config: MCPServerConfig = {
|
||||
type: "streamable-http",
|
||||
url: "https://example.com/mcp",
|
||||
headers: { "X-Key": "abc" },
|
||||
} as unknown as MCPServerConfig;
|
||||
};
|
||||
const { lastFrame } = render(
|
||||
<InfoTab
|
||||
serverName="my-server"
|
||||
serverConfig={config}
|
||||
serverSettings={headersToServerSettings({ "X-Key": "abc" })}
|
||||
serverState={baseState}
|
||||
width={80}
|
||||
height={20}
|
||||
|
|
|
|||
|
|
@ -13,6 +13,23 @@ describe("schemaToForm", () => {
|
|||
expect(form.sections[0]?.fields).toEqual([]);
|
||||
});
|
||||
|
||||
it("treats a non-object property value as an empty schema instead of throwing", () => {
|
||||
// A malformed server schema whose property value is null/primitive must not
|
||||
// crash — the field degrades to a plain string input labelled by its key.
|
||||
const form = schemaToForm(
|
||||
{ properties: { bad: null, worse: 42 } },
|
||||
"malformed",
|
||||
);
|
||||
const fields = form.sections[0]?.fields ?? [];
|
||||
expect(fields).toHaveLength(2);
|
||||
expect(
|
||||
fields.map((f) => ({ name: f.name, type: f.type, label: f.label })),
|
||||
).toEqual([
|
||||
{ name: "bad", type: "string", label: "bad" },
|
||||
{ name: "worse", type: "string", label: "worse" },
|
||||
]);
|
||||
});
|
||||
|
||||
it("maps each JSON Schema type to the matching ink-form field type", () => {
|
||||
const form = schemaToForm(
|
||||
{
|
||||
|
|
|
|||
Loading…
Reference in a new issue