chore: close quality-gate coverage gaps (#1689) (#1766)
Some checks failed
Run install, format, lint, build, and test on every push / build (push) Has been cancelled
Run install, format, lint, build, and test on every push / publish (push) Has been cancelled
Run install, format, lint, build, and test on every push / publish-github-container-registry (push) Has been cancelled

Closes #1689. Typecheck cli/tui src, add a core/ format+lint gate, and gate core/json + core/client coverage. See PR #1766 for the full review history.
This commit is contained in:
Cliff Hall 2026-07-24 17:20:12 -04:00 • committed by GitHub
commit 373f346e5f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 2210 additions and 467 deletions

View file

@ -1,7 +1,4 @@
export {
NodeOAuthStorage,
clearAllOAuthClientState,
} from "./storage-node.js";
export { NodeOAuthStorage, clearAllOAuthClientState } from "./storage-node.js";
export {
createOAuthCallbackServer,
OAuthCallbackServer,
@ -21,9 +18,7 @@ export {
parseRunnerOAuthCallbackUrl,
} from "./runner-oauth-callback.js";
export type { RunnerOAuthCallbackConfig } from "./runner-oauth-callback.js";
export {
runRunnerInteractiveOAuth,
} from "./runner-interactive-oauth.js";
export { runRunnerInteractiveOAuth } from "./runner-interactive-oauth.js";
export type {
RunRunnerInteractiveOAuthOptions,
RunnerInteractiveOAuthClient,

View file

@ -32,9 +32,7 @@ export function parseRunnerOAuthCallbackUrl(
cliCallbackUrl?: string,
): RunnerOAuthCallbackConfig {
const raw =
cliCallbackUrl?.trim() ||
process.env.MCP_OAUTH_CALLBACK_URL?.trim() ||
"";
cliCallbackUrl?.trim() || process.env.MCP_OAUTH_CALLBACK_URL?.trim() || "";
if (!raw) {
return {
hostname: RUNNER_OAUTH_CALLBACK_DEFAULT_HOSTNAME,

View file

@ -13,10 +13,7 @@
* browser side never imports this; it gets values rehydrated into the
* `/api/servers` response by the Hono handler.
*/
import {
AsyncEntry,
findCredentialsAsync,
} from "@napi-rs/keyring";
import { AsyncEntry, findCredentialsAsync } from "@napi-rs/keyring";
const SERVICE_NAME = "mcp-inspector";