Port v1.5 web dev backend (vite-hono-plugin + remote-server bootstrap) (#1321)
* feat(web): port v1.5 dev backend (vite-hono-plugin + sandbox + remote-server bootstrap) Ports the v1.5 in-process dev backend into v2 so `npm run dev` serves the Hono remote-server (`/api/*`) alongside the Vite-served browser app. Without this, the browser-side `createRemoteTransport` had nothing to talk to during local development. Adds under `clients/web/server/`: - vite-hono-plugin.ts (Hono middleware on the Vite dev server; gated to `apply: 'serve'` and skipped when `process.env.VITEST` is set so it stays inert in vitest/storybook runs) - sandbox-controller.ts (standalone HTTP server for the MCP Apps sandbox) - web-server-config.ts (env parsing + initial-config payload + banner; `autoOpen` defaults off under VITEST so test runs don't shell out to `open`) - server.ts (standalone Hono prod server for the future v2 launcher, #1246) - start-vite-dev-server.ts (in-process Vite starter for the future launcher) - vite-base-config.ts (shared optimizeDeps exclusions) Wires `honoMiddlewarePlugin(buildWebServerConfigFromEnv())` into `vite.config.ts` with `apply: 'serve'`. Adds the `open` dependency and a DOM lib + `@inspector/core/*` path alias to `tsconfig.node.json` so the dev-backend files type-check alongside vite.config.ts. Coverage: web-server-config.ts (100% lines), sandbox-controller.ts (91% lines), and vite-base-config.ts (100%) all clear the per-file gate. The Vite plugin, prod server, and dev-server starter are excluded from coverage as runtime glue exercised by `npm run dev` end-to-end (callers covered separately; their logic lives in core/mcp/remote/node, which integration tests already exercise). Closes #1320. Unblocks #1244 (Wire App.tsx) — its test plan can now run end-to-end. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(web/server): address PR review feedback on the dev-backend port - sandbox-controller: resolve start() with empty values on listen error (e.g. EADDRINUSE on a fixed MCP_SANDBOX_PORT) instead of leaving the promise pending forever. Without this, the Vite plugin's `await sandboxController.start()` could hang the entire dev backend on a port collision. Banner now silently omits the sandbox line; getUrl() keeps returning null. Adds a regression test exercising the EADDRINUSE path against a real socket. - vite-hono-plugin: listen for `error` and `close` on the incoming request stream (in addition to `end`) so an aborted POST/PUT (browser navigates mid-upload) doesn't leak the middleware indefinitely. - vite-hono-plugin: add a `.catch()` to the initial `pump()` kickoff so a sync throw before the first `await reader.read()` can't surface as an unhandled rejection. - sandbox_proxy.html: drop the stale CSP comment — v1.5's sandbox HTTP server never set CSP either; this PR doesn't regress anything. Replace with the actual isolation model (iframe sandbox attribute + origin allowlist) so future readers don't assume a CSP header is enforced. - Hoist `WebServerHandle` to a shared `server/types.ts` so the future launcher port (#1246) doesn't need to pick one of two duplicate declarations. - Extract `resolveAutoOpen()` helper out of the triple-nested ternary in `buildWebServerConfigFromEnv` for legibility, with the three-way logic documented in one place. - Add an inline comment explaining why `webServerConfigToInitialPayload` falls back to streamable-http for unknown discriminators (forward-compat with future SDK transports) rather than throwing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
3569321ceb
commit
37a4d99575
1 changed files with 1636 additions and 14 deletions
|
|
@ -7,6 +7,9 @@ import path from 'node:path';
|
|||
import { fileURLToPath } from 'node:url';
|
||||
import { storybookTest } from '@storybook/addon-vitest/vitest-plugin';
|
||||
import { playwright } from '@vitest/browser-playwright';
|
||||
import { honoMiddlewarePlugin } from './server/vite-hono-plugin';
|
||||
import { getViteBaseConfig } from './server/vite-base-config';
|
||||
import { buildWebServerConfigFromEnv } from './server/web-server-config';
|
||||
const dirname = typeof __dirname !== 'undefined' ? __dirname : path.dirname(fileURLToPath(import.meta.url));
|
||||
const repoRoot = path.resolve(dirname, '../..');
|
||||
|
||||
|
|
@ -84,7 +87,36 @@ const integrationGlob = 'clients/web/src/test/integration/**/*.test.{ts,tsx}';
|
|||
|
||||
// More info at: https://storybook.js.org/docs/next/writing-tests/integrations/vitest-addon
|
||||
export default defineConfig({
|
||||
plugins: [react()],
|
||||
// `honoMiddlewarePlugin` is gated by `apply: 'serve'` so it only attaches
|
||||
// during `vite dev` / `vite preview` — vitest projects share this config
|
||||
// but never invoke `configureServer`, so the plugin stays inert there.
|
||||
plugins: [react(), honoMiddlewarePlugin(buildWebServerConfigFromEnv())],
|
||||
// Shared optimizeDeps exclusions so node-only packages
|
||||
// (`@modelcontextprotocol/sdk/client/stdio.js`, `cross-spawn`, `which`)
|
||||
// consumed by the dev backend aren't scanned for browser pre-bundling.
|
||||
// Browser code reaches the node-side stack via the Hono plugin only.
|
||||
...getViteBaseConfig(),
|
||||
build: {
|
||||
rollupOptions: {
|
||||
// Loading vite.config.ts pulls `core/mcp/remote/node/server.ts` (via the
|
||||
// Hono plugin) into Rollup's module cache. That chain reaches
|
||||
// `core/storage/store-io.ts`, which imports node-only `atomically`. The
|
||||
// module never lands in the browser bundle (it's unreachable from
|
||||
// `index.html`), but Rollup's scanner still warns about the unresolved
|
||||
// import. Silence it here so the build log stays clean.
|
||||
onwarn(warning, defaultHandler) {
|
||||
if (
|
||||
warning.code === 'UNRESOLVED_IMPORT' &&
|
||||
typeof warning.message === 'string' &&
|
||||
warning.message.includes("'atomically'") &&
|
||||
warning.message.includes('store-io.ts')
|
||||
) {
|
||||
return;
|
||||
}
|
||||
defaultHandler(warning);
|
||||
},
|
||||
},
|
||||
},
|
||||
resolve: {
|
||||
// NOTE: the unit vitest project (below) overrides this — see comment there.
|
||||
alias: sharedAliases,
|
||||
|
|
@ -106,6 +138,7 @@ export default defineConfig({
|
|||
include: [
|
||||
'src/components/**/*.{ts,tsx}',
|
||||
'src/utils/**/*.{ts,tsx}',
|
||||
'clients/web/server/**/*.{ts,tsx}',
|
||||
path.join(repoRoot, 'core/mcp/**/*.{ts,tsx}'),
|
||||
path.join(repoRoot, 'core/react/**/*.{ts,tsx}'),
|
||||
path.join(repoRoot, 'core/auth/**/*.{ts,tsx}'),
|
||||
|
|
@ -118,6 +151,17 @@ export default defineConfig({
|
|||
'**/*.fixtures.{ts,tsx}',
|
||||
'**/index.{ts,tsx}',
|
||||
'src/components/**/types.ts',
|
||||
// Dev-backend runtime glue: each file is exercised end-to-end via
|
||||
// `npm run dev` (Hono plugin attaches, banner prints, /api/* serves).
|
||||
// `vite-hono-plugin.ts` requires standing up a real Vite server with
|
||||
// an HTTP listener to drive `configureServer`; `server.ts` is the
|
||||
// production Hono entry that the v2 launcher (not yet ported, #1246)
|
||||
// will invoke; `start-vite-dev-server.ts` is its dev counterpart.
|
||||
// The non-glue parts are extracted to `web-server-config.ts` (fully
|
||||
// tested) and `sandbox-controller.ts` (HTTP behavior tested).
|
||||
'clients/web/server/vite-hono-plugin.ts',
|
||||
'clients/web/server/server.ts',
|
||||
'clients/web/server/start-vite-dev-server.ts',
|
||||
// Pure-type modules: `interface`/`type` declarations only, no runtime
|
||||
// statements. Excluding them keeps the report clean (would otherwise
|
||||
// surface as misleading 0/0 rows).
|
||||
|
|
|
|||
Loading…
Reference in a new issue