fix: return undefined for optional arrays instead of empty arrays
- Update generateDefaultValue to return undefined for optional array parameters - Add comprehensive tests for required vs non-required arrays - Fixes issue where MCP Inspector sends empty arrays [] for optional parameters - Resolves compatibility issues with OpenAPI servers expecting omitted optionals Refs #771
This commit is contained in:
parent
0ef91d2295
commit
3cdb4bd744
2 changed files with 15 additions and 5 deletions
|
|
@ -39,8 +39,8 @@ describe("generateDefaultValue", () => {
|
||||||
).toBe(false);
|
).toBe(false);
|
||||||
});
|
});
|
||||||
|
|
||||||
test("generates default array", () => {
|
test("generates undefined for optional array", () => {
|
||||||
expect(generateDefaultValue({ type: "array" })).toEqual([]);
|
expect(generateDefaultValue({ type: "array" })).toBe(undefined);
|
||||||
});
|
});
|
||||||
|
|
||||||
test("generates default empty object", () => {
|
test("generates default empty object", () => {
|
||||||
|
|
@ -52,8 +52,18 @@ describe("generateDefaultValue", () => {
|
||||||
expect(generateDefaultValue({ type: "unknown" })).toBe(undefined);
|
expect(generateDefaultValue({ type: "unknown" })).toBe(undefined);
|
||||||
});
|
});
|
||||||
|
|
||||||
test("generates empty array for non-required array", () => {
|
test("generates empty array for required array", () => {
|
||||||
expect(generateDefaultValue({ type: "array" })).toEqual([]);
|
const parentSchema = { required: ["testArray"] };
|
||||||
|
expect(
|
||||||
|
generateDefaultValue({ type: "array" }, "testArray", parentSchema),
|
||||||
|
).toEqual([]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("generates undefined for non-required array", () => {
|
||||||
|
const parentSchema = { required: ["otherField"] };
|
||||||
|
expect(
|
||||||
|
generateDefaultValue({ type: "array" }, "testArray", parentSchema),
|
||||||
|
).toBe(undefined);
|
||||||
});
|
});
|
||||||
|
|
||||||
test("generates empty object for non-required object", () => {
|
test("generates empty object for non-required object", () => {
|
||||||
|
|
|
||||||
|
|
@ -109,7 +109,7 @@ export function generateDefaultValue(
|
||||||
case "boolean":
|
case "boolean":
|
||||||
return isRequired ? false : undefined;
|
return isRequired ? false : undefined;
|
||||||
case "array":
|
case "array":
|
||||||
return [];
|
return isRequired ? [] : undefined;
|
||||||
case "object": {
|
case "object": {
|
||||||
if (!schema.properties) return {};
|
if (!schema.properties) return {};
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue