Add enum parameter support in ToolsTab component and corresponding tests
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
parent
b7ef160190
commit
3d3a79e109
2 changed files with 101 additions and 0 deletions
|
|
@ -5,6 +5,13 @@ import { Input } from "@/components/ui/input";
|
||||||
import { Label } from "@/components/ui/label";
|
import { Label } from "@/components/ui/label";
|
||||||
import { TabsContent } from "@/components/ui/tabs";
|
import { TabsContent } from "@/components/ui/tabs";
|
||||||
import { Textarea } from "@/components/ui/textarea";
|
import { Textarea } from "@/components/ui/textarea";
|
||||||
|
import {
|
||||||
|
Select,
|
||||||
|
SelectContent,
|
||||||
|
SelectItem,
|
||||||
|
SelectTrigger,
|
||||||
|
SelectValue,
|
||||||
|
} from "@/components/ui/select";
|
||||||
import DynamicJsonForm, { DynamicJsonFormRef } from "./DynamicJsonForm";
|
import DynamicJsonForm, { DynamicJsonFormRef } from "./DynamicJsonForm";
|
||||||
import type { JsonValue, JsonSchemaType } from "@/utils/jsonUtils";
|
import type { JsonValue, JsonSchemaType } from "@/utils/jsonUtils";
|
||||||
import {
|
import {
|
||||||
|
|
@ -180,6 +187,42 @@ const ToolsTab = ({
|
||||||
{prop.description || "Toggle this option"}
|
{prop.description || "Toggle this option"}
|
||||||
</label>
|
</label>
|
||||||
</div>
|
</div>
|
||||||
|
) : prop.type === "string" && prop.enum ? (
|
||||||
|
<Select
|
||||||
|
value={
|
||||||
|
params[key] === undefined
|
||||||
|
? ""
|
||||||
|
: String(params[key])
|
||||||
|
}
|
||||||
|
onValueChange={(value) => {
|
||||||
|
if (value === "") {
|
||||||
|
setParams({
|
||||||
|
...params,
|
||||||
|
[key]: undefined,
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
setParams({
|
||||||
|
...params,
|
||||||
|
[key]: value,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<SelectTrigger id={key} className="mt-1">
|
||||||
|
<SelectValue
|
||||||
|
placeholder={
|
||||||
|
prop.description || "Select an option"
|
||||||
|
}
|
||||||
|
/>
|
||||||
|
</SelectTrigger>
|
||||||
|
<SelectContent>
|
||||||
|
{prop.enum.map((option) => (
|
||||||
|
<SelectItem key={option} value={option}>
|
||||||
|
{option}
|
||||||
|
</SelectItem>
|
||||||
|
))}
|
||||||
|
</SelectContent>
|
||||||
|
</Select>
|
||||||
) : prop.type === "string" ? (
|
) : prop.type === "string" ? (
|
||||||
<Textarea
|
<Textarea
|
||||||
id={key}
|
id={key}
|
||||||
|
|
|
||||||
|
|
@ -638,6 +638,64 @@ describe("ToolsTab", () => {
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("Enum Parameters", () => {
|
||||||
|
const toolWithEnumParam: Tool = {
|
||||||
|
name: "enumTool",
|
||||||
|
description: "Tool with enum parameter",
|
||||||
|
inputSchema: {
|
||||||
|
type: "object" as const,
|
||||||
|
properties: {
|
||||||
|
format: {
|
||||||
|
type: "string" as const,
|
||||||
|
enum: ["json", "xml", "csv", "yaml"],
|
||||||
|
description: "Output format",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
// Mock scrollIntoView for Radix UI Select
|
||||||
|
Element.prototype.scrollIntoView = jest.fn();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should render enum parameter as dropdown", () => {
|
||||||
|
renderToolsTab({
|
||||||
|
tools: [toolWithEnumParam],
|
||||||
|
selectedTool: toolWithEnumParam,
|
||||||
|
});
|
||||||
|
|
||||||
|
// Should render a select button instead of textarea
|
||||||
|
const selectTrigger = screen.getByRole("combobox", { name: /format/i });
|
||||||
|
expect(selectTrigger).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should render non-enum string parameter as textarea", () => {
|
||||||
|
const toolWithStringParam: Tool = {
|
||||||
|
name: "stringTool",
|
||||||
|
description: "Tool with regular string parameter",
|
||||||
|
inputSchema: {
|
||||||
|
type: "object" as const,
|
||||||
|
properties: {
|
||||||
|
text: {
|
||||||
|
type: "string" as const,
|
||||||
|
description: "Some text input",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
renderToolsTab({
|
||||||
|
tools: [toolWithStringParam],
|
||||||
|
selectedTool: toolWithStringParam,
|
||||||
|
});
|
||||||
|
|
||||||
|
// Should render textarea, not select
|
||||||
|
expect(screen.queryByRole("combobox")).not.toBeInTheDocument();
|
||||||
|
expect(screen.getByRole("textbox")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe("JSON Validation Integration", () => {
|
describe("JSON Validation Integration", () => {
|
||||||
const toolWithJsonParams: Tool = {
|
const toolWithJsonParams: Tool = {
|
||||||
name: "jsonTool",
|
name: "jsonTool",
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue