From 3d6280eb0ec93cb870493c34b763c21211665444 Mon Sep 17 00:00:00 2001
From: cliffhall <cliff@futurescale.com>
Date: Mon, 20 Apr 2026 15:49:14 -0400
Subject: [PATCH] Address PR #1217 code review feedback
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Fix Collapse animation: remove outer {isExpanded && ...} wrapper so
  Mantine's Collapse component drives the mount/unmount animation
- Show statusMessage for all tasks, not just active ones, so failed/
  cancelled tasks display their error reason without expanding
- Remove redundant "Status" detail row — the TaskStatusBadge in the
  header already communicates status
- Fix ttl guard: change !== null to != null to correctly handle the
  SDK's optional (undefined) field

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../components/groups/TaskCard/TaskCard.tsx   | 40 +++++++------------
 1 file changed, 14 insertions(+), 26 deletions(-)

diff --git a/clients/web/src/components/groups/TaskCard/TaskCard.tsx b/clients/web/src/components/groups/TaskCard/TaskCard.tsx
index 2868905b..2a08a183 100644
--- a/clients/web/src/components/groups/TaskCard/TaskCard.tsx
+++ b/clients/web/src/components/groups/TaskCard/TaskCard.tsx
@@ -133,10 +133,6 @@ export function TaskCard({
 
         <SummaryRow>
           <DetailRow>
-            <Stack gap={2}>
-              <DetailLabel>Status</DetailLabel>
-              <DetailValue>{status}</DetailValue>
-            </Stack>
             <Stack gap={2}>
               <DetailLabel>Last Updated</DetailLabel>
               <DetailValue>{lastUpdatedAt}</DetailValue>
@@ -145,7 +141,7 @@ export function TaskCard({
               <DetailLabel>Created At</DetailLabel>
               <DetailValue>{createdAt}</DetailValue>
             </Stack>
-            {ttl !== null && (
+            {ttl != null && (
               <Stack gap={2}>
                 <DetailLabel>TTL</DetailLabel>
                 <DetailValue>{formatTtl(ttl)}</DetailValue>
@@ -160,29 +156,21 @@ export function TaskCard({
         {progress && isActive ? (
           <ProgressDisplay params={progress} />
         ) : (
-          statusMessage &&
-          isActive && <StatusMessageText>{statusMessage}</StatusMessageText>
+          statusMessage && (
+            <StatusMessageText>{statusMessage}</StatusMessageText>
+          )
         )}
 
-        {isExpanded && (
-          <Collapse in={isExpanded}>
-            <Stack gap="sm">
-              {statusMessage && !isActive && (
-                <Stack gap={2}>
-                  <DetailLabel>Status Message</DetailLabel>
-                  <StatusMessageText>{statusMessage}</StatusMessageText>
-                </Stack>
-              )}
-
-              <Divider />
-              <SectionTitle>Full Task Object</SectionTitle>
-              <ContentViewer
-                block={{ type: "text", text: JSON.stringify(task) }}
-                copyable
-              />
-            </Stack>
-          </Collapse>
-        )}
+        <Collapse in={isExpanded}>
+          <Stack gap="sm">
+            <Divider />
+            <SectionTitle>Full Task Object</SectionTitle>
+            <ContentViewer
+              block={{ type: "text", text: JSON.stringify(task) }}
+              copyable
+            />
+          </Stack>
+        </Collapse>
       </Stack>
     </TaskContainer>
   );