modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Address PR #1211 code review feedback

Browse source 
1. ServerCard: import ConnectionStatus and ServerType from core instead
   of inline union types
2. ResourcePreviewPanel: move ContentBlock import to top of file
3. ContentViewer: remove dead annotation mimeType check in isJsonText
4. ProgressDisplay: use Pick to exclude progressToken from params type;
   remove fake tokens from callers and stories
5. AnnotationBadge: restore human-readable priority labels (high/medium/low)
   and remove unused --inspector-annotation-* CSS vars from App.css
6. MessageBubble: add fallback rendering for resource, resource_link,
   tool_use, and tool_result content block types
7. TaskControls: import TaskStatus directly from SDK instead of via TaskCard

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
cliffhall 2026-04-18 11:48:21 -04:00
commit 3e2e44ccfc
5 changed files with 31 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

3
clients/web/src/components/groups/ResourcePreviewPanel/ResourcePreviewPanel.tsx
View file

@ -1,4 +1,5 @@
import { Button, Flex, Group, Stack, Text, Title } from "@mantine/core";
import type { ContentBlock } from "@modelcontextprotocol/sdk/types.js";
import { AnnotationBadge } from "../../elements/AnnotationBadge/AnnotationBadge";
import { ContentViewer } from "../../elements/ContentViewer/ContentViewer";
import { CopyButton } from "../../elements/CopyButton/CopyButton";
@ -16,8 +17,6 @@ export interface ResourcePreviewPanelProps {
onUnsubscribe: () => void;
}
import type { ContentBlock } from "@modelcontextprotocol/sdk/types.js";
function toContentBlock(content: string, mimeType: string): ContentBlock {
if (mimeType.startsWith("image/")) {
return { type: "image", data: content, mimeType };

8
clients/web/src/components/groups/ServerCard/ServerCard.tsx
View file

@ -1,5 +1,9 @@
import { useEffect } from "react";
import { Badge, Button, Card, Group, Menu, Stack, Text } from "@mantine/core";
import type {
ConnectionStatus,
ServerType,
} from "@inspector/core/mcp/types.js";
import { ServerStatusIndicator } from "../../elements/ServerStatusIndicator/ServerStatusIndicator";
import { TransportBadge } from "../../elements/TransportBadge/TransportBadge";
import { ConnectionToggle } from "../../elements/ConnectionToggle/ConnectionToggle";
@ -9,10 +13,10 @@ import { InlineError } from "../../elements/InlineError/InlineError";
export interface ServerCardProps {
name: string;
version?: string;
transport: "stdio" | "sse" | "streamable-http";
transport: ServerType;
connectionMode: string;
command: string;
status: "connected" | "connecting" | "disconnected" | "error";
status: ConnectionStatus;
retryCount?: number;
error?: { message: string; details?: string };
canTestClientFeatures: boolean;

1
clients/web/src/components/groups/TaskCard/TaskCard.tsx
View file

@ -197,7 +197,6 @@ export function TaskCard(props: TaskCardProps) {
{progress !== undefined && isActive && (
<ProgressDisplay
params={{
progressToken: taskId,
progress,
message: progressDescription,
}}

2
clients/web/src/components/groups/TaskControls/TaskControls.tsx
View file

@ -1,5 +1,5 @@
import { Button, Group, Select, Stack, TextInput, Title } from "@mantine/core";
import type { TaskStatus } from "../TaskCard/TaskCard";
import type { TaskStatus } from "@modelcontextprotocol/sdk/types.js";
const STATUS_OPTIONS: TaskStatus[] = [
"working",

1
clients/web/src/components/groups/ToolDetailPanel/ToolDetailPanel.tsx
View file

@ -116,7 +116,6 @@ export function ToolDetailPanel({
{progress && (
<ProgressDisplay
params={{
progressToken: name,
progress: progress.percent,
message: progress.description,
}}