From 3f4f68699e4ec29ceb3a73dd993b02f954ef35ae Mon Sep 17 00:00:00 2001 From: cliffhall Date: Thu, 6 Aug 2026 09:30:39 -0400 Subject: [PATCH] fix: give smoke:web:app its own port; note the App config's era in the table MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Copilot review on #1934, both comments actionable: - smoke:web:app defaulted to 6299 — the same port smoke:web uses — while its own comment claimed the port was "distinct … so back-to-back runs can't collide". The three web smokes run sequentially in `npm run smoke`, so it passed, but a slow teardown, a TIME_WAIT socket, or a parallel run would EADDRINUSE it. Moved to 6297 (smoke:web 6299, smoke:web:browser 6298) and rewrote the comment to name the actual values rather than assert distinctness. - The showcase table tells readers to connect with Protocol Era = Modern unless noted, and mcp-app-http.json is legacy-only. That was stated in the prose below but not in the row, so a reader scanning the table would try Modern first. Marked the row. Verified: smoke:web:app passes standalone on 6297, and the full `npm run smoke` chain passes with all three web smokes on distinct ports. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_01XAR2Nr9kXbrywFNUVoTe9F --- README.md | 2 +- scripts/smoke-web-app.mjs | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index cb3f6c67..13792764 100644 --- a/README.md +++ b/README.md @@ -132,7 +132,7 @@ Each config below is a ready-made server for exercising one feature by hand. Loa | Config | Demonstrates | Issue | | ----------------------------------------- | -------------------------------------------------- | ---------------------------------------------------------------------- | -| `mcp-app-http.json` | An MCP App (UI resource + app tool) in the Apps tab | [#1859](https://github.com/modelcontextprotocol/inspector/issues/1859) | +| `mcp-app-http.json` **(legacy era)** | An MCP App (UI resource + app tool) in the Apps tab | [#1859](https://github.com/modelcontextprotocol/inspector/issues/1859) | | `modern-mrtr-http.json` | A single MRTR round-trip | — | | `mrtr-showcase-http.json` | Every MRTR preset in one server | — | | `modern-network-http.json` | Network tab: `Mcp-*` headers + error taxonomy | [#1628](https://github.com/modelcontextprotocol/inspector/issues/1628) | diff --git a/scripts/smoke-web-app.mjs b/scripts/smoke-web-app.mjs index 8387476d..e2c57b51 100644 --- a/scripts/smoke-web-app.mjs +++ b/scripts/smoke-web-app.mjs @@ -83,8 +83,10 @@ const sandboxProxyPage = join( ); const HOST = "127.0.0.1"; -// Distinct from the other web smokes' ports so back-to-back runs can't collide. -const PORT = process.env.SMOKE_WEB_APP_PORT ?? "6299"; +// Distinct from smoke:web (6299) and smoke:web:browser (6298) so a prior smoke +// whose port is still bound — slow teardown, TIME_WAIT, or a parallel run — +// can't EADDRINUSE this one. The three run back-to-back in `npm run smoke`. +const PORT = process.env.SMOKE_WEB_APP_PORT ?? "6297"; const TOKEN = "smoke-web-app-token"; const APP_TOOL = "mcp_app_demo"; // The URL the test server announces on startup. NOT derived from the config's