chore: state the smoke-helper and CI wall-clock budgets (#2333)

The five rows #2323 left as "assess", each either stated with its
reasoning and measurement, or shared with a constant that already has one.

- F4/F5: `driveAppFlow` and `connectViaDeepLink` default to
  `BROWSER_TIMEOUTS.ui` / `.roundTrip` instead of restating 30_000 /
  45_000 by hand; values unchanged, now one place to raise. A test in each
  helper pins the defaults.
- F1: `announced-child.mjs` states `DEFAULTS` ({ timeoutMs: 30_000,
  pollMs: 250 }) with the measurement — boot-to-announce of the composable
  test server is 135ms median at load average 15, and a passing start pays
  one poll interval, not the budget.
- F7: `pty.mjs` names `SCRIPT_PROBE_TIMEOUT_MS` (5s; the probe spawns in
  1.3ms median, 3.6ms max under load) and stops folding ETIMEDOUT into
  "no script(1)": a starved probe now fails `smoke:tui` loudly instead of
  turning it into an exit-0 skip.
- G1: every job in `.github/workflows/main.yml` declares
  `timeout-minutes` as a hung-job guard — roughly twice the slowest run
  observed over the last 40 push runs (and the last three releases for the
  publish jobs), rounded up to the next five minutes, with the range stated
  per job.

AGENTS.md's timeout section now points at where these live instead of at
this issue.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsmUAZ6aLUAFqenjJKSSRp
Signed-off-by: cliffhall <cliff@futurescale.com>

scripts/lib/mcp-app-flow.mjs

@@ -30,6 +30,7 @@
 
 import { join } from "node:path";
 import { startAnnouncedChild } from "./announced-child.mjs";
+import { BROWSER_TIMEOUTS } from "./browser-timeouts.mjs";
 import {
   buildConnectDeepLink,
   connectViaDeepLink,
@@ -167,6 +168,13 @@ export function buildAppDeepLink({
  * Takes only the small slice of Playwright's `page` it uses (`goto`, `locator`
  * → `waitFor`/`getAttribute`/`count`), which is what lets its failure paths be
  * unit-tested against a stand-in — a smoke only ever exercises its happy path.
+ *
+ * The three budgets are `BROWSER_TIMEOUTS` entries, not restated literals
+ * (#2333). The first two are handed straight to `connectViaDeepLink`, so the
+ * two helpers share one pair by construction. `ready` is a `roundTrip` too:
+ * the widget has to load inside the sandbox and answer through the bridge
+ * before the attribute can flip, which is the same shape as the connect wait,
+ * not a render of something already on screen (`nested`).
  */
 export async function driveAppFlow({
   page,
@@ -174,9 +182,9 @@ export async function driveAppFlow({
   expectDeepLink = true,
   what = "app",
   extraDiagnostics = null,
-  gotoTimeoutMs = 30_000,
-  connectTimeoutMs = 45_000,
-  readyTimeoutMs = 45_000,
+  gotoTimeoutMs = BROWSER_TIMEOUTS.ui,
+  connectTimeoutMs = BROWSER_TIMEOUTS.roundTrip,
+  readyTimeoutMs = BROWSER_TIMEOUTS.roundTrip,
 }) {
   // 1-2. Navigated, the deep link accepted by the token gate, and connected.
   await connectViaDeepLink({