fix: return undefined for optional objects instead of empty objects
- Update generateDefaultValue to return undefined for optional object parameters
- Add comprehensive tests for required vs non-required objects
- Fixes issue where MCP Inspector sends empty objects {} for optional parameters
- Objects with required properties still return populated objects
- Empty optional objects now return undefined to be omitted from requests
Refs #771
This commit is contained in:
parent
3cdb4bd744
commit
409ac3945d
2 changed files with 16 additions and 6 deletions
|
|
@ -43,8 +43,8 @@ describe("generateDefaultValue", () => {
|
||||||
expect(generateDefaultValue({ type: "array" })).toBe(undefined);
|
expect(generateDefaultValue({ type: "array" })).toBe(undefined);
|
||||||
});
|
});
|
||||||
|
|
||||||
test("generates default empty object", () => {
|
test("generates undefined for optional object", () => {
|
||||||
expect(generateDefaultValue({ type: "object" })).toEqual({});
|
expect(generateDefaultValue({ type: "object" })).toBe(undefined);
|
||||||
});
|
});
|
||||||
|
|
||||||
test("generates default null for unknown types", () => {
|
test("generates default null for unknown types", () => {
|
||||||
|
|
@ -66,8 +66,18 @@ describe("generateDefaultValue", () => {
|
||||||
).toBe(undefined);
|
).toBe(undefined);
|
||||||
});
|
});
|
||||||
|
|
||||||
test("generates empty object for non-required object", () => {
|
test("generates empty object for required object", () => {
|
||||||
expect(generateDefaultValue({ type: "object" })).toEqual({});
|
const parentSchema = { required: ["testObject"] };
|
||||||
|
expect(
|
||||||
|
generateDefaultValue({ type: "object" }, "testObject", parentSchema),
|
||||||
|
).toEqual({});
|
||||||
|
});
|
||||||
|
|
||||||
|
test("generates undefined for non-required object", () => {
|
||||||
|
const parentSchema = { required: ["otherField"] };
|
||||||
|
expect(
|
||||||
|
generateDefaultValue({ type: "object" }, "testObject", parentSchema),
|
||||||
|
).toBe(undefined);
|
||||||
});
|
});
|
||||||
|
|
||||||
test("generates undefined for non-required primitive types", () => {
|
test("generates undefined for non-required primitive types", () => {
|
||||||
|
|
|
||||||
|
|
@ -111,7 +111,7 @@ export function generateDefaultValue(
|
||||||
case "array":
|
case "array":
|
||||||
return isRequired ? [] : undefined;
|
return isRequired ? [] : undefined;
|
||||||
case "object": {
|
case "object": {
|
||||||
if (!schema.properties) return {};
|
if (!schema.properties) return isRequired ? {} : undefined;
|
||||||
|
|
||||||
const obj: JsonObject = {};
|
const obj: JsonObject = {};
|
||||||
// Only include properties that are required according to the schema's required array
|
// Only include properties that are required according to the schema's required array
|
||||||
|
|
@ -123,7 +123,7 @@ export function generateDefaultValue(
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
return obj;
|
return isRequired ? obj : Object.keys(obj).length > 0 ? obj : undefined;
|
||||||
}
|
}
|
||||||
case "null":
|
case "null":
|
||||||
return null;
|
return null;
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue