modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Merge pull request #2351 from modelcontextprotocol/v2/chore/2346-gate-lease-test-tmp-cleanup

Browse source 
chore: remove gate-lease.test.mjs temp directories after the suite
This commit is contained in:
Cliff Hall 2026-09-13 12:23:44 -04:00 • committed by GitHub
commit 4673e04e13
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 19 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

22
scripts/gate-lease.test.mjs
View file

@ -5,7 +5,7 @@
// behind (or block) a developer's actual gate. Run via `npm run test:scripts`
// (node:test; the root has no vitest harness).
import { test } from "node:test";
import { after, test } from "node:test";
import assert from "node:assert/strict";
import { spawn } from "node:child_process";
import {
@ -41,11 +41,27 @@ import {
const SCRIPT = fileURLToPath(new URL("./gate-lease.mjs", import.meta.url));
/** A fresh lease directory per test, so tests never contend with each other. */
/**
* A fresh lease directory per test, so tests never contend with each other.
* Each one is recorded so the suite can remove it once every test is done
* (#2346): one hook, rather than a try/finally in each of the fourteen tests,
* and it runs whether a test passed, failed, or threw before its own cleanup.
*/
const createdDirs = [];
function freshDir() {
return mkdtempSync(join(tmpdir(), "gate-lease-test-"));
const dir = mkdtempSync(join(tmpdir(), "gate-lease-test-"));
createdDirs.push(dir);
return dir;
}
// Runs once all tests in the file have finished. Every test that starts a
// child (or the wrapper) awaits its exit before asserting, so by now nothing
// is holding a lock inside any of these directories, and a stray lock or
// holder record a test left on purpose is just a directory to remove.
after(() => {
for (const dir of createdDirs) rmSync(dir, { recursive: true, force: true });
});
function collectLog() {
const lines = [];
return { lines, log: (line) => lines.push(line) };