Phase 4: Move screen selection state into the screens themselves

ToolsScreen, PromptsScreen, and ResourcesScreen each tracked the user's
current selection via `selectedXxxName` / `onSelectXxx` props, hoisting
screen-local UI state into whatever rendered them. InspectorView never
threaded those callbacks anywhere, so clicks in the controls panel did
not display the matching detail panel — the detail panel only rendered
if a parent fed selection back in.

Move selection into `useState` inside each screen and drop the
`selectedXxxName` / `onSelectXxx` props. MCP-derived data (`callState`,
`getPromptState`, `readState`) keeps flowing in from `InspectorView` as
props. ResourcesScreen wraps `onReadResource` so a template-expanded URI
becomes the selected resource for preview rendering.

Update each screen's stories to drop the deleted props. Stories that
need a pre-selected item use a `play` function to click it — no
component coupling to Storybook.

Add Phase 4.3 to the interfaces plan describing the rule.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
cliffhall 2026-04-26 09:27:22 -04:00
commit 4c1d2f2c34

View file

@ -17,11 +17,9 @@ export interface ToolCallState {
export interface ToolsScreenProps {
tools: Tool[];
selectedToolName?: string;
callState?: ToolCallState;
listChanged: boolean;
onRefreshList: () => void;
onSelectTool: (name: string) => void;
onCallTool: (name: string, args: Record<string, unknown>) => void;
onCancelCall?: () => void;
onClearResult?: () => void;
@ -58,15 +56,16 @@ const EmptyState = Text.withProps({
export function ToolsScreen({
tools,
selectedToolName,
callState,
listChanged,
onRefreshList,
onSelectTool,
onCallTool,
onCancelCall,
onClearResult,
}: ToolsScreenProps) {
const [selectedToolName, setSelectedToolName] = useState<string | undefined>(
undefined,
);
const [formValues, setFormValues] = useState<Record<string, unknown>>({});
const selectedTool = selectedToolName
? tools.find((t) => t.name === selectedToolName)
@ -84,7 +83,7 @@ export function ToolsScreen({
onRefreshList={onRefreshList}
onSelectTool={(name) => {
setFormValues({});
onSelectTool(name);
setSelectedToolName(name);
}}
/>
</SidebarCard>