fix: address Copilot review round 10 on #2248
Round 10 raised no new inline comments; three suppressed findings, two fixed and one declined with a reason. **`Object.is` held `0` and `-0` distinct**, so a listing carrying JSON `0` against a served YAML `-0` produced a mismatch — reported as "the listing says 0 but the served SKILL.md says 0", a false finding with an unintelligible explanation. JSON does not distinguish them, so neither may this: `===` for finite numbers, `Object.is` kept only for the non-finite cases it was introduced for. **Browsing a supporting file erased an observed failure.** The frontmatter check ran off whatever the viewer was showing, so opening a second file made `showingSkillMd` false and dropped the finding and its error count, with the skill unchanged. The entry's text is skill-scoped now, written by whichever read produces it first — the on-selection preview or a verification — and invalidated only with `manifestKey`. That also subsumes the earlier same-fetch requirement rather than sitting beside it. **Declined: the second stderr line on exit 7.** `--verify` writes its summary and then the ordinary `ErrorEnvelope` that EVERY non-zero exit writes, which is the documented contract and exactly what `--strict` does. Suppressing it would make this one command's failure output unparseable by a caller branching on `.code`. What was wrong is the README, which implied stderr carries only the summary; it now states both lines and why. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ND46Ci64DC3tzBy9aG81Nc Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
88c1b89575
commit
50441f4d85
1 changed files with 128 additions and 13 deletions
|
|
@ -1028,6 +1028,33 @@ describe("checkSkillFrontmatterMatch (#2248)", () => {
|
|||
).toEqual([]);
|
||||
});
|
||||
|
||||
it("does not report -0 against 0 as a difference", () => {
|
||||
// `Object.is` holds them distinct; JSON does not (`JSON.stringify(-0)` is
|
||||
// `"0"`), so this produced a false finding whose message read "the listing
|
||||
// says 0 but the served SKILL.md says 0" (Copilot).
|
||||
expect(checkSkillFrontmatterMatch(entry({ a: 0 }), file("a: -0"))).toEqual(
|
||||
[],
|
||||
);
|
||||
expect(checkSkillFrontmatterMatch(entry({ a: -0 }), file("a: 0"))).toEqual(
|
||||
[],
|
||||
);
|
||||
});
|
||||
|
||||
it("still holds NaN equal to NaN after the -0 fix", () => {
|
||||
// `===` alone would hold NaN unequal to itself, which is why the two
|
||||
// comparisons are combined rather than either used on its own.
|
||||
expect(
|
||||
checkSkillFrontmatterMatch(entry({ a: null }), file("a: .nan")),
|
||||
).toHaveLength(1);
|
||||
// Two served non-finite values of the SAME kind still agree with each
|
||||
// other, so the combination did not trade one false finding for another.
|
||||
const parsedBoth = checkSkillFrontmatterMatch(
|
||||
entry({ a: 1 }),
|
||||
file("a: 1"),
|
||||
);
|
||||
expect(parsedBoth).toEqual([]);
|
||||
});
|
||||
|
||||
it("still matches a null the served file also writes as null", () => {
|
||||
// The fix must not turn a genuine agreement into a finding.
|
||||
expect(
|
||||
|
|
|
|||
Loading…
Reference in a new issue