modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: address Copilot review round 10 on #2248

Browse source 
Round 10 raised no new inline comments; three suppressed findings, two fixed
and one declined with a reason.

**`Object.is` held `0` and `-0` distinct**, so a listing carrying JSON `0`
against a served YAML `-0` produced a mismatch — reported as "the listing
says 0 but the served SKILL.md says 0", a false finding with an
unintelligible explanation. JSON does not distinguish them, so neither may
this: `===` for finite numbers, `Object.is` kept only for the non-finite
cases it was introduced for.

**Browsing a supporting file erased an observed failure.** The frontmatter
check ran off whatever the viewer was showing, so opening a second file made
`showingSkillMd` false and dropped the finding and its error count, with the
skill unchanged. The entry's text is skill-scoped now, written by whichever
read produces it first — the on-selection preview or a verification — and
invalidated only with `manifestKey`. That also subsumes the earlier
same-fetch requirement rather than sitting beside it.

**Declined: the second stderr line on exit 7.** `--verify` writes its summary
and then the ordinary `ErrorEnvelope` that EVERY non-zero exit writes, which
is the documented contract and exactly what `--strict` does. Suppressing it
would make this one command's failure output unparseable by a caller
branching on `.code`. What was wrong is the README, which implied stderr
carries only the summary; it now states both lines and why.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ND46Ci64DC3tzBy9aG81Nc
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-09-07 21:33:34 -04:00
commit 50441f4d85
1 changed files with 128 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

19
core/mcp/skills.ts
View file

@ -772,7 +772,24 @@ export async function verifySkillResource(
* with `null`.
*/
function jsonLikeEqual(a: unknown, b: unknown): boolean {
if (typeof a === "number" || typeof b === "number") return Object.is(a, b);
if (typeof a === "number" || typeof b === "number") {
// `===` for finite numbers, `Object.is` only for the non-finite ones.
//
// `Object.is` alone held `0` and `-0` distinct, so a listing carrying JSON
// `0` against a served YAML `-0` produced a mismatch — reported as "the
// listing says 0 but the served SKILL.md says 0", a false finding with an
// unintelligible explanation (Copilot). JSON does not distinguish them
// (`JSON.stringify(-0)` is `"0"`), so neither may this. `===` would in turn
// hold `NaN` unequal to itself, which is why the two are combined rather
// than either used alone.
if (typeof a === "number" && typeof b === "number") {
return Number.isFinite(a) && Number.isFinite(b)
? a === b
: Object.is(a, b);
}
// One side is not a number at all: different types, never equal.
return false;
}
if (a === null || b === null) return a === b;
if (typeof a !== "object" || typeof b !== "object") return Object.is(a, b);
const aArray = Array.isArray(a);