fix(core): read state stores during render instead of re-syncing in an effect
Every state-subscription hook in core/react/ seeded local React state from its store prop and re-synced it inside a useEffect. That shape paints one frame of the previous store's data when the prop changes (switching servers), and loses any event dispatched between the render that took the snapshot and the effect that attached the listener. Convert all 16 to useSyncExternalStore through a new shared useStoreSnapshot, following useManagedListError (#1954). useSyncExternalStore needs a referentially stable snapshot, and these getters hand back a defensive copy, so TypedEventTarget now keeps a per-event-type dispatch counter (getEventRevision) that the snapshot is cached against. A contents comparison would not do: MessageLogState folds a response into its request entry by mutating that entry in place, which a shallow compare reports as unchanged. The bump lives on the dispatchEvent override so no dispatch — including a hand-rolled CustomEvent — can bypass it. useInspectorClient is included though the issue did not list it; its nine subscribed slices made the stale frame most visible. Its lastError stays useState (accumulated from events, no getter to read back) but resets on client swap during render rather than in an effect. The settings-draft and async fetch hooks are deliberately untouched: the former hold genuinely local editable state, the latter are I/O rather than store subscriptions. Also answers the issue's open question. react-hooks/set-state-in-effect never fired here because eslint-plugin-react-hooks has never linted core/react/ at all — it is a clients/web devDependency and the root config loads no React plugin. Corrected the config comment that gave "no JSX" as the reason; the gap itself is #2192, measured at 15 findings, none of them in the hooks converted here. Closes #1955 Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
8c91ae8820
commit
50502269f4
1 changed files with 987 additions and 772 deletions
|
|
@ -8,8 +8,21 @@ import { defineConfig, globalIgnores } from "eslint/config";
|
|||
// (#1689) and the root-owned "shared" surface — `test-servers/src/**`, the
|
||||
// root `vitest.shared.mts`, and this config file itself (#1767). `core/` is
|
||||
// isomorphic TypeScript (browser-side OAuth + Node backends + shared runtime);
|
||||
// the shared surface is Node-only tooling/tests. Neither has JSX, so no React
|
||||
// plugin is needed.
|
||||
// the shared surface is Node-only tooling/tests.
|
||||
//
|
||||
// ⚠️ There is no React plugin here, and "neither surface has JSX" is NOT a
|
||||
// sufficient reason for that — `core/react/` is a directory of React hooks,
|
||||
// which the hook rules judge whether or not any JSX is present. So the whole
|
||||
// `eslint-plugin-react-hooks` set, `set-state-in-effect` included, has never
|
||||
// looked at them: it is a devDependency of `clients/web` only, and Node
|
||||
// resolution walks up rather than down, so the root cannot even load it.
|
||||
// That is why the prop-into-effect re-sync #1955 fixed sat here unreported
|
||||
// while the identical shape is an error over in `clients/web/src`. Closing the
|
||||
// gap means adding the plugin at the root and taking what it then reports —
|
||||
// measured during #1955 as 15 findings, every one of them in a hook that issue
|
||||
// did not convert (the two settings-draft hooks and the three async fetch
|
||||
// hooks) and none in the 16 it did. Tracked on its own rather than folded in.
|
||||
//
|
||||
// Type-aware linting for the two blocks below. `no-floating-promises` needs
|
||||
// type information, which `tseslint.configs.recommended` (the non-type-aware
|
||||
// set) does not provide — so each block adds a parser project (#1959).
|
||||
|
|
|
|||
Loading…
Reference in a new issue