chore(lint): enable no-floating-promises in all five ESLint scopes

A floated promise is invisible at review time — the call reads like an
awaited one minus four characters — and the unhandled rejection it
produces surfaces in a different test, in a different file, as a stack
pointing at SDK internals. In #1947 two un-held `callTool` calls made
`npm run ci` unpassable and took a full investigation to attribute; the
fix was two lines. `@typescript-eslint/no-floating-promises` catches the
class outright, so enable it at `error` everywhere.

The rule is type-aware and `tseslint.configs.recommended` is not, so each
scope's config gains a parser project. The four clients name their own
tsconfig projects (both of them — `src` and `__tests__`/`server` live in
different ones). The root scope has no tsconfig at all, so add
`tsconfig.lint.json`: a lint-only project covering `core/**`,
`test-servers/src/**`, and `vitest.shared.mts`, emitting nothing and
gating nothing. It sets `moduleResolution: bundler` deliberately — under
NodeNext `core/`'s extensionless imports fail to resolve, every import
degrades to `any`, and the rule silently stops seeing promises at all.

Measured surface, and the fixes:

- core (2) — `stream.close()` in two Hono `onAbort` listeners. Hono
  invokes subscribers with a bare `subscriber()`, so a promise returned
  from the listener is floated one layer up; `closeAbortedStream` owns
  the rejection where it can actually be owned.
- tui (5) — `handleDisconnect` had no catch of its own and its only
  caller is a key handler that cannot await, so a failing disconnect was
  a live unhandled rejection; it now surfaces the message the way
  `handleConnect` does. The rest are `void` at callers that genuinely
  cannot await, over callees that already own their failures.
- web (92) — 83 are Storybook `expect(...)`, which is instrumented and
  returns a promise, now awaited (`scrollAreaStoryAssertions` is async
  for the same reason). Two tests were asserting against a provider call
  they never awaited. `open(url)` in both web servers now warns instead
  of escaping a synchronous callback.
- cli, launcher — already clean.

Type-aware linting costs time: `clients/web`'s `eslint .` goes from ~8s
to ~19s, inside `validate`. Narrowing the loaded projects is the lever if
that needs reducing later; dropping the rule is not.

Closes #1959

Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-08-16 20:57:32 -04:00
commit 519ecf49ee

View file

@ -99,6 +99,22 @@ import { ZodError } from "zod";
*/
const SSE_PRIMING_COMMENT = ":\n\n";
/**
* Close an SSE stream from inside an `onAbort` listener, discarding the
* rejection.
*
* `close()` is async and the peer is, by definition, already gone here — a
* write that loses the race rejects with nothing left to recover. The listener
* itself cannot own the promise either: Hono's `abort()` invokes subscribers
* with a bare `subscriber()` (`hono/utils/stream`), so a promise *returned*
* from the listener is floated by Hono rather than awaited, turning an
* `async` listener into the same unhandled rejection one layer up. Swallowing
* it here is the only place the rejection has an owner.
*/
function closeAbortedStream(stream: { close(): Promise<void> }): void {
stream.close().catch(() => {});
}
/**
* Shape of the initial config returned by GET /api/config (defaults for client).
*/
@ -854,7 +870,7 @@ export function createRemoteApp(
stream.onAbort(() => {
// Client disconnected - clear event consumer
const shouldCleanup = session.clearEventConsumer();
stream.close();
closeAbortedStream(stream);
// If transport is dead and no client connected, cleanup session
if (shouldCleanup || session.isTransportDead()) {
@ -2460,7 +2476,7 @@ export function createRemoteApp(
stream.onAbort(() => {
serverEventSubscribers.delete(send);
void maybeStopWatcher();
stream.close();
closeAbortedStream(stream);
});
// Hono closes the stream the moment this callback returns, so hold the