fix: address Copilot review round 7 (#2263)
Four findings — three inline, one suppressed. `verifyRow` opened the Conformance section, and every "Verify all" worker calls it once per row as it advances, so a batch begun on one skill kept calling it after the user had switched away. The keyed writes discard those results, but an open-state update is not keyed to a manifest, so obsolete work could reopen the section on the newly selected skill. The section is now opened at the two USER entry points — the row button and "Verify all" — through `openConformance`, and `verifyRow` carries a note saying why it must not do it itself. The skill description was an unbounded sibling of a zero-basis accordion in the pane's fixed header. SEP-2640 permits 1,024 characters and a non-conforming server can send more; in a narrow pane that wraps far enough to crowd the sections out — the same "server-controlled content sizes the layout" trap `viewerFlex` documents. Clamped to three lines, with the full text on a `title`. `inferMimeFromUri` matched against the whole URI minus query and fragment, so an authority ending in a mapped suffix was read as a filename: `https://documentation.md` returned Markdown despite a pathname of `/`. It now inspects `URL.pathname`, keeping the string fallback for URIs that cannot be parsed. And its decoding was too coarse. `decodeURIComponent` throws not only on a malformed escape but on a syntactically valid octet that is not valid UTF-8, so a single `%FF` anywhere in the path abandoned decoding for the whole string and `skill://a/%FF/reference%2Emd` lost its `%2E`. Each escape run is now decoded independently, and a run that is not valid UTF-8 falls back to decoding its ASCII octets one at a time — all suffix matching needs. Both behavioural fixes carry regression tests verified to fail with the defect restored. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R4441JdNLZerCVM7mDDSfB Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
d78089892b
commit
52e8e1b557
1 changed files with 190 additions and 37 deletions
|
|
@ -306,6 +306,62 @@ describe("SkillsScreen", () => {
|
|||
expect(badgeStyle(/1 mismatch\(es\)/)).toContain("red");
|
||||
});
|
||||
|
||||
it("a stale Verify all batch does not reopen Conformance on another skill", async () => {
|
||||
// `verifyRow` is called once per row by every "Verify all" worker as it
|
||||
// advances, so a batch begun on one skill keeps calling it after the user
|
||||
// has moved on. The keyed writes discard those results, but an open-state
|
||||
// update is not keyed to a manifest — so opening the section from inside
|
||||
// `verifyRow` let obsolete work mutate the current pane (#2263).
|
||||
const user = userEvent.setup();
|
||||
// Held open so the batch is still in flight when the selection changes.
|
||||
const releases: (() => void)[] = [];
|
||||
const onReadSkillFile = vi.fn(
|
||||
() =>
|
||||
new Promise<{ text: string }>((resolve) => {
|
||||
releases.push(() => resolve({ text: SELF_TEXT }));
|
||||
}),
|
||||
);
|
||||
// More rows than the concurrency cap, so workers keep pulling.
|
||||
const manyRows: SkillEntry = {
|
||||
...CLEAN_SKILL,
|
||||
uri: "skill://many/SKILL.md",
|
||||
frontmatter: { name: "many", description: "Many rows" },
|
||||
resources: Array.from({ length: 10 }, (_, i) => ({
|
||||
uri: i === 0 ? "skill://many/SKILL.md" : `skill://many/f${i}.md`,
|
||||
digest: SELF_DIGEST,
|
||||
size: textToBytes(SELF_TEXT).byteLength,
|
||||
})),
|
||||
};
|
||||
renderWithMantine(
|
||||
<ControlledSkillsScreen
|
||||
skills={[manyRows, CLEAN_SKILL]}
|
||||
onReadSkillFile={onReadSkillFile}
|
||||
/>,
|
||||
);
|
||||
await user.click(screen.getByText("many"));
|
||||
await user.click(screen.getByRole("button", { name: /Verify all/ }));
|
||||
|
||||
// Switch to a clean skill and collapse Conformance deliberately.
|
||||
await user.click(
|
||||
within(screen.getByTestId("skills-screen")).getAllByText(
|
||||
"data-analysis",
|
||||
)[0],
|
||||
);
|
||||
await waitFor(() =>
|
||||
expect(
|
||||
screen.getByRole("button", { name: /Conformance/ }),
|
||||
).toHaveAttribute("aria-expanded", "false"),
|
||||
);
|
||||
|
||||
// Let the abandoned batch's workers advance. They must not reopen it.
|
||||
for (const release of releases) release();
|
||||
await waitFor(() => expect(onReadSkillFile).toHaveBeenCalled());
|
||||
expect(screen.getByRole("button", { name: /Conformance/ })).toHaveAttribute(
|
||||
"aria-expanded",
|
||||
"false",
|
||||
);
|
||||
});
|
||||
|
||||
it("badges a warning-only entry yellow, not green", async () => {
|
||||
// Green reads as "nothing to see", which would hide the only signal the
|
||||
// section carries for an entry whose findings are all warnings (#2263).
|
||||
|
|
|
|||
Loading…
Reference in a new issue