fix: state every test-gate timeout instead of inheriting a library default
Three of the six Vitest projects ran on Vitest's own testTimeout: 5000 and five on its hookTimeout/teardownTimeout: 10000, and all 788 Testing Library waits in the web unit project ran on asyncUtilTimeout: 1000. None of those numbers was chosen here, and all of them were sized for an idle machine rather than for three or four concurrent worktree sessions each running a full local:gate on eight cores. #2292, #2278, #2250, #1942 and #1742 were each that class, diagnosed one site at a time. This is the complement of #1596, not a retreat from it: every fix that issue produced stands, and no race is hidden here. What changes is that a correct, deterministic test is no longer cut off by a budget nobody picked. - vitest.shared.mts exports frozen TIMEOUTS / INTEGRATION_TIMEOUTS; all six projects spread one of them, clients/launcher importing the shared module for the first time to do so. - Both web projects configure Testing Library's asyncUtilTimeout. The storybook one needs its own setup file, deliberately outside .storybook/ and free of setProjectAnnotations so the automatic preview-annotation provisioning (#1898) is untouched. - 28 per-suite restatements of the integration project's own budget are gone, so raising the shared value now moves every site under it. The handful that genuinely differ — cross-process lock contention, a full OAuth round trip — keep their budget as a named constant that says why. - AppRenderer's waitFor no longer asks for exactly its enclosing budget, which it could never win (#2292's shape); cli's e2e child timer drops below the project budget so the bound carrying the diagnostic is the one that fires. - The transition auto-settle's slack term is named RAF_SLACK_MS and raised; the term derived from HEADER_ANIM_MS is untouched. The two answer to different things and must not be scaled as one number. - The 19 Playwright budgets scattered across three web smokes become four named constants in scripts/lib/browser-timeouts.mjs. scripts/verify-test-timeouts.mjs resolves each project through Vitest itself and asserts the budgets, the asyncUtilTimeout sites, and that retry stays unset. It was observed red against the pre-change config: unit/tui/launcher at testTimeout 5000, five projects at hookTimeout 10000, both asyncUtilTimeout sites unmet. Closes #2323 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsmUAZ6aLUAFqenjJKSSRp Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
336e045210
commit
58e53d5a92
3 changed files with 1276 additions and 394 deletions
|
|
@ -27,11 +27,23 @@ const tick = async () => {
|
|||
await new Promise((resolve) => setTimeout(resolve, 4));
|
||||
};
|
||||
|
||||
/** Poll the frame until it contains `substr` — stable under coverage load. */
|
||||
/**
|
||||
* Poll the frame until it contains `substr` — stable under coverage load.
|
||||
*
|
||||
* The default budget (`tries` x the ~32ms `tick` below) matches `App.test.tsx`'s
|
||||
* `POLL_TRIES`, which was raised twice for exactly this shape (#1742, #1942).
|
||||
* It used to be 25 here — one third of the same renderer's budget under the
|
||||
* same v8 instrumentation, for no stated reason, which made this the next one
|
||||
* to go red. A high ceiling costs a passing assertion nothing: the loop returns
|
||||
* the instant the predicate holds and only the slow path ever spends it
|
||||
* (#2323).
|
||||
*/
|
||||
const POLL_TRIES = 100;
|
||||
|
||||
async function waitForFrame(
|
||||
getFrame: () => string | undefined,
|
||||
substr: string,
|
||||
tries = 25,
|
||||
tries = POLL_TRIES,
|
||||
) {
|
||||
for (let i = 0; i < tries; i++) {
|
||||
if ((getFrame() ?? "").includes(substr)) return;
|
||||
|
|
|
|||
|
|
@ -9,8 +9,19 @@ import { join } from "node:path";
|
|||
* file (and any parent dir) appears a tick later. Awaiting this before cleanup
|
||||
* also guarantees the background mkdir/open has finished, so `afterEach`'s
|
||||
* rmSync can't race it into an ENOENT.
|
||||
*
|
||||
* The budget is a ceiling, not a wait: the loop exits on the first `existsSync`
|
||||
* that succeeds, so a passing run pays only the 20ms poll interval and the
|
||||
* headroom is spent only when a real filesystem write is genuinely slow — which
|
||||
* is what an oversubscribed machine produces (#2323). 2000ms was Vitest-era
|
||||
* guesswork against an idle one.
|
||||
*/
|
||||
async function waitForFile(filePath: string, timeoutMs = 2000): Promise<void> {
|
||||
const FILE_APPEAR_TIMEOUT_MS = 10_000;
|
||||
|
||||
async function waitForFile(
|
||||
filePath: string,
|
||||
timeoutMs = FILE_APPEAR_TIMEOUT_MS,
|
||||
): Promise<void> {
|
||||
const start = Date.now();
|
||||
while (!existsSync(filePath)) {
|
||||
if (Date.now() - start > timeoutMs) {
|
||||
|
|
|
|||
|
|
@ -1,7 +1,7 @@
|
|||
import path from "node:path";
|
||||
import { fileURLToPath } from "node:url";
|
||||
import { defineConfig } from "vitest/config";
|
||||
import { vitestSharedPaths } from "../../vitest.shared.mts";
|
||||
import { TIMEOUTS, vitestSharedPaths } from "../../vitest.shared.mts";
|
||||
|
||||
const dirname = path.dirname(fileURLToPath(import.meta.url));
|
||||
const { projectResolve } = vitestSharedPaths(dirname);
|
||||
|
|
@ -13,6 +13,10 @@ export default defineConfig({
|
|||
environment: "node",
|
||||
include: ["__tests__/**/*.test.{ts,tsx}"],
|
||||
setupFiles: ["./__tests__/setup.ts"],
|
||||
// Shared budgets (#2323). Ink renders through React, so every assertion
|
||||
// here waits on a React commit under v8 instrumentation — the shape behind
|
||||
// the poll-budget raises in #1742 and #1942.
|
||||
...TIMEOUTS,
|
||||
coverage: {
|
||||
provider: "v8",
|
||||
reporter: ["text", "html", "json-summary"],
|
||||
|
|
|
|||
Loading…
Reference in a new issue