fix: state every test-gate timeout instead of inheriting a library default
Three of the six Vitest projects ran on Vitest's own testTimeout: 5000 and five on its hookTimeout/teardownTimeout: 10000, and all 788 Testing Library waits in the web unit project ran on asyncUtilTimeout: 1000. None of those numbers was chosen here, and all of them were sized for an idle machine rather than for three or four concurrent worktree sessions each running a full local:gate on eight cores. #2292, #2278, #2250, #1942 and #1742 were each that class, diagnosed one site at a time. This is the complement of #1596, not a retreat from it: every fix that issue produced stands, and no race is hidden here. What changes is that a correct, deterministic test is no longer cut off by a budget nobody picked. - vitest.shared.mts exports frozen TIMEOUTS / INTEGRATION_TIMEOUTS; all six projects spread one of them, clients/launcher importing the shared module for the first time to do so. - Both web projects configure Testing Library's asyncUtilTimeout. The storybook one needs its own setup file, deliberately outside .storybook/ and free of setProjectAnnotations so the automatic preview-annotation provisioning (#1898) is untouched. - 28 per-suite restatements of the integration project's own budget are gone, so raising the shared value now moves every site under it. The handful that genuinely differ — cross-process lock contention, a full OAuth round trip — keep their budget as a named constant that says why. - AppRenderer's waitFor no longer asks for exactly its enclosing budget, which it could never win (#2292's shape); cli's e2e child timer drops below the project budget so the bound carrying the diagnostic is the one that fires. - The transition auto-settle's slack term is named RAF_SLACK_MS and raised; the term derived from HEADER_ANIM_MS is untouched. The two answer to different things and must not be scaled as one number. - The 19 Playwright budgets scattered across three web smokes become four named constants in scripts/lib/browser-timeouts.mjs. scripts/verify-test-timeouts.mjs resolves each project through Vitest itself and asserts the budgets, the asyncUtilTimeout sites, and that retry stays unset. It was observed red against the pre-change config: unit/tui/launcher at testTimeout 5000, five projects at hookTimeout 10000, both asyncUtilTimeout sites unmet. Closes #2323 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsmUAZ6aLUAFqenjJKSSRp Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
336e045210
commit
58e53d5a92
1 changed files with 1276 additions and 394 deletions
|
|
@ -1,6 +1,25 @@
|
|||
import "@testing-library/jest-dom/vitest";
|
||||
import { afterEach } from "vitest";
|
||||
import { cleanup } from "@testing-library/react";
|
||||
import { cleanup, configure } from "@testing-library/react";
|
||||
|
||||
// Testing Library's own `asyncUtilTimeout` default is 1000ms
|
||||
// (`@testing-library/dom/dist/config.js`), and it governs every `waitFor` and
|
||||
// `findBy*` in the unit project — 788 call sites — none of which chose it. One
|
||||
// `configure` call is the whole surface, which is why it is here rather than
|
||||
// argued a site at a time (#2323).
|
||||
//
|
||||
// 5x, because a contended happy-dom render is the worst-measured case on this
|
||||
// team's machine (8 logical cores, three or four concurrent worktree sessions
|
||||
// each free to run the full `local:gate`), and because once the project's
|
||||
// `testTimeout` rises to 15000 this becomes the *binding* constraint on every
|
||||
// async assertion in the project — the enclosing budget stops being the thing
|
||||
// that cuts a wait short and this starts being it.
|
||||
//
|
||||
// The trade-off, stated rather than hidden: a genuinely-failing async
|
||||
// assertion now takes 5s to report instead of 1s. Only failing assertions pay
|
||||
// it, once each, on runs that are already the slow path. A *passing* `waitFor`
|
||||
// returns the instant its callback stops throwing and is unaffected.
|
||||
configure({ asyncUtilTimeout: 5000 });
|
||||
|
||||
// Node 22+ exposes an experimental `localStorage` placeholder that overrides
|
||||
// happy-dom's implementation. Without `--localstorage-file`, it's an empty
|
||||
|
|
|
|||
Loading…
Reference in a new issue