fix: state every test-gate timeout instead of inheriting a library default
Three of the six Vitest projects ran on Vitest's own testTimeout: 5000 and five on its hookTimeout/teardownTimeout: 10000, and all 788 Testing Library waits in the web unit project ran on asyncUtilTimeout: 1000. None of those numbers was chosen here, and all of them were sized for an idle machine rather than for three or four concurrent worktree sessions each running a full local:gate on eight cores. #2292, #2278, #2250, #1942 and #1742 were each that class, diagnosed one site at a time. This is the complement of #1596, not a retreat from it: every fix that issue produced stands, and no race is hidden here. What changes is that a correct, deterministic test is no longer cut off by a budget nobody picked. - vitest.shared.mts exports frozen TIMEOUTS / INTEGRATION_TIMEOUTS; all six projects spread one of them, clients/launcher importing the shared module for the first time to do so. - Both web projects configure Testing Library's asyncUtilTimeout. The storybook one needs its own setup file, deliberately outside .storybook/ and free of setProjectAnnotations so the automatic preview-annotation provisioning (#1898) is untouched. - 28 per-suite restatements of the integration project's own budget are gone, so raising the shared value now moves every site under it. The handful that genuinely differ — cross-process lock contention, a full OAuth round trip — keep their budget as a named constant that says why. - AppRenderer's waitFor no longer asks for exactly its enclosing budget, which it could never win (#2292's shape); cli's e2e child timer drops below the project budget so the bound carrying the diagnostic is the one that fires. - The transition auto-settle's slack term is named RAF_SLACK_MS and raised; the term derived from HEADER_ANIM_MS is untouched. The two answer to different things and must not be scaled as one number. - The 19 Playwright budgets scattered across three web smokes become four named constants in scripts/lib/browser-timeouts.mjs. scripts/verify-test-timeouts.mjs resolves each project through Vitest itself and asserts the budgets, the asyncUtilTimeout sites, and that retry stays unset. It was observed red against the pre-change config: unit/tui/launcher at testTimeout 5000, five projects at hookTimeout 10000, both asyncUtilTimeout sites unmet. Closes #2323 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsmUAZ6aLUAFqenjJKSSRp Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
336e045210
commit
58e53d5a92
1 changed files with 1276 additions and 394 deletions
|
|
@ -64,6 +64,7 @@ import { setTimeout as delay } from "node:timers/promises";
|
|||
import { fileURLToPath } from "node:url";
|
||||
import { dirname, resolve } from "node:path";
|
||||
import { startProdWebServer } from "./lib/prod-web-server.mjs";
|
||||
import { BROWSER_TIMEOUTS } from "./lib/browser-timeouts.mjs";
|
||||
import {
|
||||
attachPageDiagnostics,
|
||||
loadBrowser,
|
||||
|
|
@ -135,7 +136,7 @@ try {
|
|||
// authenticates without a query param.
|
||||
const response = await page.goto(server.baseUrl, {
|
||||
waitUntil: "domcontentloaded",
|
||||
timeout: 30_000,
|
||||
timeout: BROWSER_TIMEOUTS.ui,
|
||||
});
|
||||
if (!response || !response.ok()) {
|
||||
throw new Error(
|
||||
|
|
@ -145,12 +146,12 @@ try {
|
|||
// First meaningful frame: the always-present "Add Servers" control.
|
||||
await page
|
||||
.getByRole("button", { name: /Add Servers/ })
|
||||
.waitFor({ state: "visible", timeout: 30_000 });
|
||||
.waitFor({ state: "visible", timeout: BROWSER_TIMEOUTS.ui });
|
||||
// Settle window: let lazily-evaluated chunks that throw a tick after first
|
||||
// paint surface before we assert a clean boot. networkidle is best-effort
|
||||
// (the Google-Fonts request may never idle on a restricted network).
|
||||
await page
|
||||
.waitForLoadState("networkidle", { timeout: 5_000 })
|
||||
.waitForLoadState("networkidle", { timeout: BROWSER_TIMEOUTS.bestEffort })
|
||||
.catch(() => {});
|
||||
await delay(500);
|
||||
};
|
||||
|
|
|
|||
Loading…
Reference in a new issue