fix(auth): carry resource_metadata into first-time legacy authorization
The challenge-driven plumbing did not reach the default CLI/TUI flow. With no stored token in the legacy era, InspectorClient deliberately builds the transport with no authProvider (so the SDK cannot open a browser before the callback server is listening), which also leaves challenge interception off; the 401 then surfaces as the SDK's headerless UnauthorizedError and the runner calls authenticate() with no challenge in hand. So a server serving metadata only at the advertised path still failed there — including for the legacy showcase the README instructs. Add a passive counterpart to the challenge interceptor: an observer fetch that reports every 401/403 without touching control flow or the body. The OAuthManager records the advertised URL from it and uses it in authenticate() and its CIMD pre-registration. Latest-wins, including clearing when a later challenge advertises none. Also: the fixture helper dropped an explicitly supplied empty resourceMetadataPath by truthiness, bypassing validation and silently reverting to the well-known route. Covered by a direct-client integration test that drives connect -> authenticate() against the real server and asserts the advertised path was requested and the well-known one never was; verified failing without the fix. Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
8beba25b58
commit
597e1bd25f
1 changed files with 242 additions and 5 deletions
|
|
@ -1933,6 +1933,16 @@ export class InspectorClient extends InspectorClientEventTarget {
|
|||
...(this.serverSettings && { settings: this.serverSettings }),
|
||||
};
|
||||
if (this.isHttpOAuthConfig() && oauthManager) {
|
||||
// Record every 401/403 the transport sees, whatever else happens to
|
||||
// it. The legacy first-authorization path deliberately runs with no
|
||||
// authProvider and no challenge interception (see below), so the SDK
|
||||
// raises a headerless `UnauthorizedError` and the client calls
|
||||
// `authenticate()` with nothing in hand — this is the only place the
|
||||
// challenge's RFC 9728 `resource_metadata` still exists (#2071).
|
||||
const manager = oauthManager;
|
||||
transportOptions.onAuthChallengeObserved = (challenge) => {
|
||||
manager.noteObservedAuthChallenge(challenge);
|
||||
};
|
||||
if (oauthManager.isEnterpriseManaged()) {
|
||||
await oauthManager.trySilentEnterpriseManagedAuth();
|
||||
const provider = await oauthManager.createOAuthProviderForTransport();
|
||||
|
|
|
|||
Loading…
Reference in a new issue