docs: a reply does not resolve a review thread
Copilot review round 1 on #2273: the text said only a reply in the thread "can resolve it", which is wrong — resolution is a separate act (the Resolve conversation button, or the resolveReviewThread GraphQL mutation) and it is the reviewer's to make. Reading it as satisfied by the documented REST reply is exactly the wrong conclusion for a PR whose whole point is what a reply does. State what the reply actually buys: it is the only thing a reviewer reading that thread sees, and it is what makes resolving the thread defensible. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017nLLLTGc37hQiC8s3mNyhq Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
f504b89b56
commit
5a1b5900cf
1 changed files with 6 additions and 3 deletions
|
|
@ -282,8 +282,11 @@ arrive late (see step 8).
|
|||
- After making the changes, **reply to each review comment in its own thread**
|
||||
with what was done, or why it was declined. That inline reply is the primary
|
||||
response and it is not optional — each review comment is a discussion thread
|
||||
with its own resolve state, and only a reply _in_ the thread can resolve it or
|
||||
show a reviewer reading it that the finding was answered.
|
||||
with its own resolve state, and a reply _in_ the thread is the only thing a
|
||||
reviewer reading that thread sees. It does **not** resolve the thread:
|
||||
resolving is a separate act — the "Resolve conversation" button, or the
|
||||
`resolveReviewThread` GraphQL mutation — and it is the reviewer's to make. The
|
||||
reply is what makes resolving it defensible.
|
||||
|
||||
```sh
|
||||
# Fetch the round's comments by REVIEW id — the unpaginated /reviews listing
|
||||
|
|
|
|||
Loading…
Reference in a new issue