test(oauth): prove the opt-out against a real authorization server
Copilot review round 3 on #2114. The unit tests asserted our own `grant_types` array and stopped there. What actually unblocks an Entra tenant is what the SDK puts in the authorize URL, and nothing covered that — so an SDK change that stopped keying its augmentation off `grant_types` would leave AADSTS90094 intact with every test green. Adds the complementary case to the existing e2e suite, against a real AS advertising `offline_access`: with the grant declined, the authorize URL carries neither `offline_access` nor `prompt=consent`, while the configured scope still goes out. Verified non-vacuous by reverting the provider conditional — it fails. The positive test alongside it now also asserts `prompt=consent` is present, which was unasserted despite being the literal failure in the issue. Drops an unjustified `as unknown as ServerEntry` I added in the App test — AGENTS.md forbids it, and it hid a real mismatch (a partial settings object against a complete one). Typed `ServerEntry` / `InspectorServerSettings` fixtures instead, so a field added to that interface later is a compile error rather than a missing value at runtime. The `constructedOAuth` helper reads through the constructor's own parameter type and needs no cast at all now. Scopes the two doc comments that still claimed the flag removes every `offline_access` — `StoredMCPServer.oauth` and `OAuthProviderConfig`, both contradicting the caveat already stated elsewhere. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013hzwzS8UvBsr4yZm7o7sev Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
fca3f1ce67
commit
6303f8a6ce
1 changed files with 125 additions and 22 deletions
|
|
@ -496,9 +496,11 @@ describe("OAuthNavigation", () => {
|
|||
});
|
||||
|
||||
// The point of the opt-out: the SDK's determineScope() only appends
|
||||
// `offline_access` when the client metadata declares `refresh_token`, and
|
||||
// startAuthorization() only forces `prompt=consent` when `offline_access`
|
||||
// is in scope. Dropping the grant is what breaks that chain.
|
||||
// `offline_access` when the client metadata declares `refresh_token`.
|
||||
// This asserts our half — the grant list. That the authorize URL then
|
||||
// carries neither `offline_access` nor `prompt=consent` is proved against
|
||||
// a real AS in the e2e suite (inspectorClient-oauth-e2e.test.ts), since
|
||||
// the SDK, not this array, is what ultimately writes that URL.
|
||||
it("drops the refresh_token grant when disabled", () => {
|
||||
expect(
|
||||
makeProviderWithRefresh(false).clientMetadata.grant_types,
|
||||
|
|
|
|||
Loading…
Reference in a new issue