fix(web): make sidebar lists, monitor panels, and Tools placeholder fill height (#1663) (#1664)

Three related "fill the available height" layout fixes to the connected screens:

- Tools & Prompts sidebars: replace the fixed magic max-height on ToolControls/
  PromptControls with the Resources pattern — sidebar Card `variant="sidebar"`
  (full-height flex column) + `Stack flex={1} mih={0}` + a flex-filling
  ScrollArea — so the list runs to the bottom of the card before scrolling.
- Logs/Console/Protocol/Network standalone screens: only override ScreenLayout
  `h` when embedded. Passing `h={undefined}` clobbered the default
  `h: calc(100dvh - header)` (withProps plain-spreads), collapsing an empty
  screen to its controls' height. Also center the Network/Protocol empty states.
- Tools placeholder: render the "Select a tool" empty state in a full-height
  `DetailCard flex={1}` (like Prompts/Resources) instead of the content-sized
  preview card, so it fills the pane.


Claude-Session: https://claude.ai/code/session_015sMW1YZXkM7fDkdPtHpE95

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Cliff Hall 2026-07-11 18:45:50 -04:00 • committed by GitHub
commit 6722438428
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 93 additions and 35 deletions

View file

@ -34,10 +34,17 @@ const PanelContainer = Paper.withProps({
variant: "panel", variant: "panel",
}); });
// Centered in the full-height panel so the empty message sits mid-panel rather
// than clinging to the top of an otherwise-empty box (matches LogStreamPanel).
const EmptyCenter = Stack.withProps({
flex: 1,
align: "center",
justify: "center",
});
const EmptyState = Text.withProps({ const EmptyState = Text.withProps({
c: "dimmed", c: "dimmed",
ta: "center", ta: "center",
py: "xl",
}); });
function formatTitle(count: number): string { function formatTitle(count: number): string {
@ -133,7 +140,9 @@ export function NetworkStreamPanel({
</Group> </Group>
{!hasResults ? ( {!hasResults ? (
<EmptyState>No network requests</EmptyState> <EmptyCenter>
<EmptyState>No network requests</EmptyState>
</EmptyCenter>
) : ( ) : (
<EmbeddableScrollArea <EmbeddableScrollArea
embedded={embedded} embedded={embedded}

View file

@ -17,9 +17,6 @@ export interface PromptControlsProps {
onSelectPrompt: (name: string) => void; onSelectPrompt: (name: string) => void;
} }
const LIST_MAX_HEIGHT =
"calc(100vh - var(--app-shell-header-height, 0px) - var(--mantine-spacing-xl) * 2 - 160px)";
export function PromptControls({ export function PromptControls({
prompts, prompts,
selectedName, selectedName,
@ -39,7 +36,10 @@ export function PromptControls({
); );
return ( return (
<Stack gap="sm"> // Fill the full-height `sidebar` Card (a flex column) so the list runs to the
// bottom of the card before it scrolls, instead of being capped short by a
// fixed max-height. `mih: 0` lets the scroll child shrink and scroll.
<Stack gap="sm" flex={1} mih={0}>
<Group justify="space-between"> <Group justify="space-between">
<Title order={4}>Prompts</Title> <Title order={4}>Prompts</Title>
<ListChangedIndicator visible={listChanged} onRefresh={onRefreshList} /> <ListChangedIndicator visible={listChanged} onRefresh={onRefreshList} />
@ -53,7 +53,7 @@ export function PromptControls({
searchText ? <ClearButton onClick={() => onSearchChange("")} /> : null searchText ? <ClearButton onClick={() => onSearchChange("")} /> : null
} }
/> />
<ScrollArea.Autosize viewportRef={viewportRef} mah={LIST_MAX_HEIGHT}> <ScrollArea viewportRef={viewportRef} flex={1} mih={0} type="auto">
<Stack gap="xs"> <Stack gap="xs">
{filteredPrompts.map((prompt) => ( {filteredPrompts.map((prompt) => (
<PromptListItem <PromptListItem
@ -66,7 +66,7 @@ export function PromptControls({
/> />
))} ))}
</Stack> </Stack>
</ScrollArea.Autosize> </ScrollArea>
</Stack> </Stack>
); );
} }

View file

@ -54,10 +54,17 @@ const PanelContainer = Paper.withProps({
variant: "panel", variant: "panel",
}); });
// Centered in the full-height panel so the empty message sits mid-panel rather
// than clinging to the top of an otherwise-empty box (matches LogStreamPanel).
const EmptyCenter = Stack.withProps({
flex: 1,
align: "center",
justify: "center",
});
const EmptyState = Text.withProps({ const EmptyState = Text.withProps({
c: "dimmed", c: "dimmed",
ta: "center", ta: "center",
py: "xl",
}); });
// The section header is a single "pleat" bar (rounded, with the filter-button // The section header is a single "pleat" bar (rounded, with the filter-button
@ -293,7 +300,9 @@ export function ProtocolListPanel({
</Group> </Group>
{!hasResults ? ( {!hasResults ? (
<EmptyState>No request history</EmptyState> <EmptyCenter>
<EmptyState>No request history</EmptyState>
</EmptyCenter>
) : ( ) : (
<EmbeddableScrollArea embedded={embedded} viewportRef={viewportRef}> <EmbeddableScrollArea embedded={embedded} viewportRef={viewportRef}>
<Stack gap="md"> <Stack gap="md">

View file

@ -17,9 +17,6 @@ export interface ToolControlsProps {
onSelectTool: (name: string) => void; onSelectTool: (name: string) => void;
} }
const LIST_MAX_HEIGHT =
"calc(100vh - var(--app-shell-header-height, 0px) - var(--mantine-spacing-xl) * 2 - 160px)";
export function ToolControls({ export function ToolControls({
tools, tools,
selectedName, selectedName,
@ -40,7 +37,12 @@ export function ToolControls({
: tools; : tools;
return ( return (
<Stack gap="sm"> // Fill the full-height `sidebar` Card (a flex column) so the scroll region
// below claims all the remaining space under the fixed title/search — the
// list runs to the bottom of the card before it scrolls, instead of being
// capped short by a fixed max-height. `mih: 0` lets the scroll child shrink
// and scroll rather than overflow the card.
<Stack gap="sm" flex={1} mih={0}>
<Group justify="space-between"> <Group justify="space-between">
<Title order={4}>Tools</Title> <Title order={4}>Tools</Title>
<ListChangedIndicator visible={listChanged} onRefresh={onRefreshList} /> <ListChangedIndicator visible={listChanged} onRefresh={onRefreshList} />
@ -54,7 +56,7 @@ export function ToolControls({
searchText ? <ClearButton onClick={() => onSearchChange("")} /> : null searchText ? <ClearButton onClick={() => onSearchChange("")} /> : null
} }
/> />
<ScrollArea.Autosize viewportRef={viewportRef} mah={LIST_MAX_HEIGHT}> <ScrollArea viewportRef={viewportRef} flex={1} mih={0} type="auto">
<Stack gap="xs"> <Stack gap="xs">
{filteredTools.map((tool) => ( {filteredTools.map((tool) => (
<ToolListItem <ToolListItem
@ -67,7 +69,7 @@ export function ToolControls({
/> />
))} ))}
</Stack> </Stack>
</ScrollArea.Autosize> </ScrollArea>
</Stack> </Stack>
); );
} }

View file

@ -124,7 +124,10 @@ export function ConsoleScreen({
}, [entries, filterText, sortDirection]); }, [entries, filterText, sortDirection]);
return ( return (
<ScreenLayout h={embedded ? "100%" : undefined}> // See LoggingScreen: only override `h` when embedded, so the standalone
// screen keeps ScreenLayout's default full-screen height (a `h={undefined}`
// would clobber it and collapse an empty screen to its controls' height).
<ScreenLayout {...(embedded ? { h: "100%" } : {})}>
{embedded ? null : ( {embedded ? null : (
<Sidebar> <Sidebar>
<SidebarCard> <SidebarCard>

View file

@ -78,7 +78,11 @@ export function LoggingScreen({
} }
return ( return (
<ScreenLayout h={embedded ? "100%" : undefined}> // Embedded fills the monitoring sidebar column (100%); standalone keeps the
// ScreenLayout's default full-screen height. Passing `h={undefined}` here
// would clobber that default (withProps plain-spreads), collapsing an empty
// screen to its controls' height — so only override `h` when embedded.
<ScreenLayout {...(embedded ? { h: "100%" } : {})}>
{embedded ? null : ( {embedded ? null : (
<Sidebar> <Sidebar>
<SidebarCard> <SidebarCard>

View file

@ -84,7 +84,10 @@ export function NetworkScreen({
} }
return ( return (
<ScreenLayout h={embedded ? "100%" : undefined}> // See LoggingScreen: only override `h` when embedded, so the standalone
// screen keeps ScreenLayout's default full-screen height (a `h={undefined}`
// would clobber it and collapse an empty screen to its controls' height).
<ScreenLayout {...(embedded ? { h: "100%" } : {})}>
{embedded ? null : ( {embedded ? null : (
<Sidebar> <Sidebar>
<SidebarCard> <SidebarCard>

View file

@ -69,9 +69,13 @@ const Sidebar = Stack.withProps({
flex: "0 0 auto", flex: "0 0 auto",
}); });
// `sidebar` variant makes the card a full-height flex column capped at the
// screen height, so PromptControls' list fills the card and scrolls internally
// once it overflows (matching the Resources sidebar).
const SidebarCard = Card.withProps({ const SidebarCard = Card.withProps({
withBorder: true, withBorder: true,
padding: "lg", padding: "lg",
variant: "sidebar",
}); });
const DetailCard = Card.withProps({ const DetailCard = Card.withProps({

View file

@ -104,7 +104,10 @@ export function ProtocolScreen({
}, [ui, visibleDirections, onUiChange]); }, [ui, visibleDirections, onUiChange]);
return ( return (
<ScreenLayout h={embedded ? "100%" : undefined}> // See LoggingScreen: only override `h` when embedded, so the standalone
// screen keeps ScreenLayout's default full-screen height (a `h={undefined}`
// would clobber it and collapse an empty screen to its controls' height).
<ScreenLayout {...(embedded ? { h: "100%" } : {})}>
{embedded ? null : ( {embedded ? null : (
<Sidebar> <Sidebar>
<SidebarCard> <SidebarCard>

View file

@ -79,9 +79,13 @@ const Sidebar = Stack.withProps({
flex: "0 0 auto", flex: "0 0 auto",
}); });
// `sidebar` variant makes the card a full-height flex column capped at the
// screen height, so ToolControls' list fills the card and scrolls internally
// once it overflows (matching the Resources sidebar). (#1417)
const SidebarCard = Card.withProps({ const SidebarCard = Card.withProps({
withBorder: true, withBorder: true,
padding: "lg", padding: "lg",
variant: "sidebar",
}); });
// Column wrapper: stretches to the screen's available height (capped by the // Column wrapper: stretches to the screen's available height (capped by the
@ -102,6 +106,15 @@ const ContentCard = Card.withProps({
variant: "preview", variant: "preview",
}); });
// Full-height card for the empty placeholder (used with `flex={1}`) so it fills
// the screen height like the Prompts/Resources placeholders, rather than
// shrinking to its text. The result/detail states keep the content-sized
// `ContentCard` (their inner ScrollArea handles overflow).
const DetailCard = Card.withProps({
withBorder: true,
padding: "lg",
});
const EmptyState = Text.withProps({ const EmptyState = Text.withProps({
c: "dimmed", c: "dimmed",
ta: "center", ta: "center",
@ -160,21 +173,25 @@ export function ToolsScreen({
</SidebarCard> </SidebarCard>
</Sidebar> </Sidebar>
<ContentPane mah={SCROLL_MAX_HEIGHT}> {callState?.result ? (
<ContentCard> // Results replace the input form while present, and the panel's top-left
{callState?.result ? ( // X dismisses them back to the form (#1661) — the Prompts screen pattern.
// Results replace the input form while present, and the panel's // `formValues` live in the lifted UI state, so the form is restored
// top-left X dismisses them back to the form (#1661) — the Prompts // intact for a re-run. A call in flight sets a `pending` state with no
// screen pattern. `formValues` live in the lifted UI state, so the // `result` (App.tsx), so the executing form (progress + cancel) shows
// form is restored intact for a re-run. A call in flight sets a // until the result lands.
// `pending` state with no `result` (App.tsx), so the executing form <ContentPane mah={SCROLL_MAX_HEIGHT}>
// (progress + cancel) shows until the result lands. <ContentCard>
<ToolResultPanel <ToolResultPanel
result={callState.result} result={callState.result}
onClear={() => onClearResult?.()} onClear={() => onClearResult?.()}
onReadResource={onReadResource} onReadResource={onReadResource}
/> />
) : selectedTool ? ( </ContentCard>
</ContentPane>
) : selectedTool ? (
<ContentPane mah={SCROLL_MAX_HEIGHT}>
<ContentCard>
<ToolDetailPanel <ToolDetailPanel
tool={selectedTool} tool={selectedTool}
formValues={formValues} formValues={formValues}
@ -193,11 +210,15 @@ export function ToolsScreen({
} }
onCancel={() => onCancelCall?.()} onCancel={() => onCancelCall?.()}
/> />
) : ( </ContentCard>
<EmptyState>Select a tool to view details</EmptyState> </ContentPane>
)} ) : (
</ContentCard> // Empty placeholder fills the full screen height (like Prompts/Resources)
</ContentPane> // rather than shrinking to its text.
<DetailCard flex={1}>
<EmptyState>Select a tool to view details</EmptyState>
</DetailCard>
)}
</ScreenLayout> </ScreenLayout>
); );
} }