modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix(smoke): pin the teardown ordering, and correct a docblock the test refuted

Browse source 
Both round-3 review points, both mine.

1. The docblock claimed deleting `removeSafe` would leave "both the unit suite
   and all three smokes green" — written before the test existed and never
   updated, so it contradicted the test added in the same PR. Only the smokes
   would stay green; the unit tests are precisely what fails on it.

2. `assert.ok(hasExited(child))` after the await proved only that the child was
   dead by the time teardown returned. It passes just as happily if the catalog
   were removed *first*, or while an un-awaited `stopChild` was still pending —
   so it did not lock down the #1801 ordering it claimed to.

   Sample the directory from the child's own `exit` handler instead, registered
   before teardown so it runs ahead of stopChild's listener and observes the
   world at the instant the child dies. `removeSafe` cannot have run by then: it
   is sequenced after the promise stopChild resolves from that very event.

Mutation-checked against both defects the old assertion missed — removing before
stopping, and dropping the await. Each now fails the test; neither did before.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HDdo1rNRVQnVRRdsqSrvG3
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-08-11 15:17:56 -04:00
commit 678184ed3e
1 changed files with 24 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

9
scripts/lib/prod-web-server.mjs
View file

@ -89,10 +89,11 @@ export function buildWebServerEnv({
* never turn a passing smoke red.
*
* Exported separately from `startProdWebServer` so the teardown *contract* is
* testable against a stand-in child, without booting a real launcher. Testing it
* matters more than it looks: deleting the `removeSafe` call would leave both the
* unit suite and all three smokes green (the smokes exit immediately after
* teardown), which is precisely the regression the tests exist to catch.
* testable against a stand-in child, without booting a real launcher. That split
* is what makes the leak detectable at all: the smokes exit immediately after
* teardown, so deleting the `removeSafe` call below would leave all three of them
* green. The focused unit tests in `prod-web-server.test.mjs` are the only thing
* that fails on it.
*
* @param {object} opts
* @param {import("node:child_process").ChildProcess} opts.child