refactor: assert retry and asyncUtilTimeout at runtime, delete the source scanner
Round 8 of the review asked for an AST. That was the right diagnosis of the
wrong problem: the question was never which parser to use, it was why a
test-timeout guard was parsing JavaScript at all.
It got there one reasonable step at a time. The guard enforces two rules no
Vitest config can report — a per-test `retry`, and Testing Library's
`asyncUtilTimeout` — so it read them out of source text, and the review found a
new valid spelling it missed in five consecutive rounds: a trailing comment,
nested parens in `it.each([makeCase()])`, a member-access prefix, the shorthand
`{ retry }`, an aliased import, a non-literal title. Each fix was correct and
each made it more parser-shaped, until it carried eight helpers doing quote
tracking and bracket balancing.
Both rules are observable at runtime, exactly:
- `vitest.setup.shared.mts` is loaded by all six projects and reads
`ctx.task.retry` — the value Vitest resolved for the test. That covers
strictly more than the scan did: a per-test option, a `describe` option
inherited by children, a project-level setting, and a `--retry` flag typed at
a command line, which the scan could never see since it only read npm scripts.
- `clients/web/src/test/asyncUtilTimeout.test.ts` asserts
`getConfig().asyncUtilTimeout`, the value this project's own waitFors read.
Neither has a spelling to anticipate, so neither can be outrun by a new one.
Both were observed firing before being trusted.
The guard keeps only what it can answer by asking Vitest: resolved budgets,
project-level retry, config discovery, and that each project still loads the
setup file — the one thing about the runtime assertion a config CAN report.
868 lines to 361, every scanner helper gone, and 33 of 48 unit tests deleted
because they pinned edge cases of a thing that no longer exists.
storybookSetup.ts goes with it. At the library's own value its configure() call
was a no-op, and the assertion is what pins the number.
AGENTS.md gains the general rule: a rule about what the code DOES is asserted at
runtime, not read out of the source — reach for a verify:* guard when the
question is about configuration, which a tool can be asked to resolve.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsmUAZ6aLUAFqenjJKSSRp
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
5b80a5d834
commit
69e6097b68
1 changed files with 228 additions and 799 deletions
|
|
@ -16,6 +16,7 @@ import { buildWebServerConfigFromEnv } from "./server/web-server-config";
|
|||
import { createBrowserExternalizedBuiltinGate } from "./server/browser-externalized-builtin-gate";
|
||||
import {
|
||||
INTEGRATION_TIMEOUTS,
|
||||
NO_RETRY_SETUP,
|
||||
TIMEOUTS,
|
||||
vitestSharedPaths,
|
||||
} from "../../vitest.shared.mts";
|
||||
|
|
@ -318,7 +319,10 @@ export default defineConfig(({ command }) => {
|
|||
include: ["clients/web/src/**/*.test.{ts,tsx}"],
|
||||
// Integration tests run in the integration project below (node env).
|
||||
exclude: [integrationGlob],
|
||||
setupFiles: [path.join(dirname, "src/test/setup.ts")],
|
||||
setupFiles: [
|
||||
path.join(dirname, "src/test/setup.ts"),
|
||||
NO_RETRY_SETUP,
|
||||
],
|
||||
// Pin after-hooks to LIFO (reverse registration). This is Vitest 4's
|
||||
// own default (`resolved.sequence.hooks ??= "stack"` — the CLI
|
||||
// help-text's "parallel" is stale), so this line documents intent and
|
||||
|
|
@ -357,6 +361,7 @@ export default defineConfig(({ command }) => {
|
|||
// can transform core/ modules and run tests against the source.
|
||||
root: repoRoot,
|
||||
include: [integrationGlob],
|
||||
setupFiles: [NO_RETRY_SETUP],
|
||||
// Integration tests spawn real HTTP/stdio servers via test-servers/,
|
||||
// bind sockets, run e2e OAuth flows, and exercise filesystem-backed
|
||||
// storage. 30s matches the v1.5 core/vitest.config.ts. Now stated
|
||||
|
|
@ -402,11 +407,13 @@ export default defineConfig(({ command }) => {
|
|||
// now follow it rather than restate it. The hook and teardown
|
||||
// budgets come along with it, having been left on the defaults.
|
||||
...TIMEOUTS,
|
||||
// One `configure({ asyncUtilTimeout })` call, and deliberately not
|
||||
// in `.storybook/` — see the file's own header for why that
|
||||
// location and the absence of `setProjectAnnotations` are what keep
|
||||
// the automatic preview-annotation provisioning below intact.
|
||||
setupFiles: [path.join(dirname, "src/test/storybookSetup.ts")],
|
||||
// Carries the shared no-retry assertion and nothing else.
|
||||
// ⚠️ It is deliberately NOT in `.storybook/` and declares no
|
||||
// annotations: `@storybook/addon-vitest` skips its automatic
|
||||
// preview-annotation provisioning only for a setup file that is
|
||||
// both inside `configDir` and calls `setProjectAnnotations`, and
|
||||
// this one is neither (#1898).
|
||||
setupFiles: [NO_RETRY_SETUP],
|
||||
browser: {
|
||||
enabled: true,
|
||||
headless: true,
|
||||
|
|
|
|||
Loading…
Reference in a new issue