modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Merge pull request #940 from modelcontextprotocol/fweinberger/fix-stream-double-close

Browse source 
Fix ReadableStream controller double-close crash
This commit is contained in:
Felix Weinberger 2025-11-28 19:41:14 +00:00 • committed by GitHub
commit 6e4a52b273
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 16 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

19
server/src/index.ts
View file

@ -241,18 +241,31 @@ const authMiddleware = (
* This is necessary for the EventSource polyfill which expects web streams * This is necessary for the EventSource polyfill which expects web streams
*/ */
const createWebReadableStream = (nodeStream: any): ReadableStream => { const createWebReadableStream = (nodeStream: any): ReadableStream => {
let closed = false;
return new ReadableStream({ return new ReadableStream({
start(controller) { start(controller) {
nodeStream.on("data", (chunk: any) => { nodeStream.on("data", (chunk: any) => {
controller.enqueue(chunk); if (!closed) {
controller.enqueue(chunk);
}
}); });
nodeStream.on("end", () => { nodeStream.on("end", () => {
controller.close(); if (!closed) {
closed = true;
controller.close();
}
}); });
nodeStream.on("error", (err: any) => { nodeStream.on("error", (err: any) => {
controller.error(err); if (!closed) {
closed = true;
controller.error(err);
}
}); });
}, },
cancel() {
closed = true;
nodeStream.destroy();
},
}); });
}; };