test(coverage): bootstrap vitest unit infra and add tests at 90%+ per file (#1245) (#1269)

* test(coverage): bootstrap vitest unit infra and add tests at 90%+ per file (#1245)

Establishes the unit-test runtime AGENTS.md mandates: a vitest "unit"
project alongside the existing storybook project, RTL + jest-dom +
happy-dom, a Mantine-aware render helper, and a 90%-line per-file
coverage gate enforced by CI. Adds 66 test files covering all 62
components under elements/groups/screens/views, plus core/mcp and
clients/web/src/utils. Total: 577 tests, 98.7% line coverage globally.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(coverage): address PR #1269 review feedback

- AGENTS.md: correct coverage gate description (lines ≥ 90, statements ≥ 85,
  functions ≥ 80, branches ≥ 50) with rationale for the relaxed branch
  threshold
- InspectorView.test.tsx: document what the Math.random() mock values
  (0.1 / 0.99) control vs. STUB_SUCCESS_RATE in InspectorView.tsx
- vite.config.ts / tsconfig.test.json: drop unused `globals: true` and the
  `vitest/globals` type now that every test file imports describe/it/expect/vi
  explicitly; manual `afterEach(cleanup)` in setup.ts remains required because
  testing-library auto-cleanup relies on globalThis.afterEach

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Cliff Hall 2026-05-01 15:15:32 -04:00 • committed by GitHub
commit 75f74d64c1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -0,0 +1,149 @@
import { describe, it, expect, vi } from "vitest";
import userEvent from "@testing-library/user-event";
import type { ElicitRequest } from "@modelcontextprotocol/sdk/types.js";
import { renderWithMantine, screen } from "../../../test/renderWithMantine";
import { InlineElicitationRequest } from "./InlineElicitationRequest";
const formRequest = {
message: "Please provide your database connection details.",
requestedSchema: {
type: "object" as const,
properties: {
host: { type: "string" as const, title: "Host" },
port: { type: "string" as const, title: "Port" },
},
},
} satisfies ElicitRequest["params"];
const urlRequest: ElicitRequest["params"] = {
mode: "url",
message: "Please authenticate via the external URL.",
url: "https://example.com/auth/callback?session=abc123",
elicitationId: "elicit-abc-123",
};
const baseProps = {
queuePosition: "1 of 1",
onChange: vi.fn(),
onSubmit: vi.fn(),
onCancel: vi.fn(),
};
describe("InlineElicitationRequest", () => {
it("renders the form badge, message, and queue position in form mode", () => {
renderWithMantine(
<InlineElicitationRequest
{...baseProps}
request={formRequest}
values={{}}
/>,
);
expect(screen.getByText("elicitation/create (form)")).toBeInTheDocument();
expect(screen.getByText(formRequest.message)).toBeInTheDocument();
expect(screen.getByText("1 of 1")).toBeInTheDocument();
});
it("renders schema fields and a Submit button in form mode", () => {
renderWithMantine(
<InlineElicitationRequest
{...baseProps}
request={formRequest}
values={{}}
/>,
);
expect(screen.getByText("Host")).toBeInTheDocument();
expect(screen.getByText("Port")).toBeInTheDocument();
expect(screen.getByRole("button", { name: "Submit" })).toBeInTheDocument();
});
it("invokes onSubmit when Submit is clicked", async () => {
const user = userEvent.setup();
const onSubmit = vi.fn();
renderWithMantine(
<InlineElicitationRequest
{...baseProps}
request={formRequest}
values={{}}
onSubmit={onSubmit}
/>,
);
await user.click(screen.getByRole("button", { name: "Submit" }));
expect(onSubmit).toHaveBeenCalledTimes(1);
});
it("invokes onCancel when Cancel is clicked", async () => {
const user = userEvent.setup();
const onCancel = vi.fn();
renderWithMantine(
<InlineElicitationRequest
{...baseProps}
request={formRequest}
values={{}}
onCancel={onCancel}
/>,
);
await user.click(screen.getByRole("button", { name: "Cancel" }));
expect(onCancel).toHaveBeenCalledTimes(1);
});
it("invokes onChange when a schema field changes", async () => {
const user = userEvent.setup();
const onChange = vi.fn();
renderWithMantine(
<InlineElicitationRequest
{...baseProps}
request={formRequest}
values={{}}
onChange={onChange}
/>,
);
await user.type(screen.getByLabelText("Host"), "x");
expect(onChange).toHaveBeenCalled();
});
it("renders the URL badge and url in url mode", () => {
renderWithMantine(
<InlineElicitationRequest {...baseProps} request={urlRequest} />,
);
expect(screen.getByText("elicitation/create (url)")).toBeInTheDocument();
expect(screen.getByText(urlRequest.url)).toBeInTheDocument();
});
it("does not render Submit button in url mode", () => {
renderWithMantine(
<InlineElicitationRequest {...baseProps} request={urlRequest} />,
);
expect(
screen.queryByRole("button", { name: "Submit" }),
).not.toBeInTheDocument();
});
it("shows the waiting indicator when isWaiting is true", () => {
renderWithMantine(
<InlineElicitationRequest
{...baseProps}
request={urlRequest}
isWaiting
/>,
);
expect(screen.getByText("Waiting...")).toBeInTheDocument();
});
it("hides the waiting indicator when isWaiting is false", () => {
renderWithMantine(
<InlineElicitationRequest
{...baseProps}
request={urlRequest}
isWaiting={false}
/>,
);
expect(screen.queryByText("Waiting...")).not.toBeInTheDocument();
});
it("uses an empty values object when values prop is undefined", () => {
renderWithMantine(
<InlineElicitationRequest {...baseProps} request={formRequest} />,
);
expect(screen.getByText("Host")).toBeInTheDocument();
});
});