From 77e978f3181c9acfe55c0f93079472016f097e2a Mon Sep 17 00:00:00 2001 From: cliffhall Date: Tue, 25 Aug 2026 01:24:40 -0400 Subject: [PATCH] docs(scripts): correct smoke-web-app's stale "built on demand" header MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Round 2's suppressed finding, and a fair one: smoke-web-app.mjs reaches the build through `startMcpAppServer` rather than calling the helper itself, so its header survived the sweep still claiming `test-servers/build` is "built on demand if missing" — the exact policy this PR removes. It is also the smoke that found the defect, so the header now says so. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_01JTHVxSu8AUgHRLvo1ntZ8H Signed-off-by: cliffhall --- scripts/smoke-web-app.mjs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/smoke-web-app.mjs b/scripts/smoke-web-app.mjs index 9019d8aa..d4ea5c7d 100644 --- a/scripts/smoke-web-app.mjs +++ b/scripts/smoke-web-app.mjs @@ -42,8 +42,11 @@ * would only find later. * * Expects `clients/web/dist` and `clients/launcher/build` to be built first — - * the validate / CI ordering guarantees this. `test-servers/build` is built on - * demand if missing, as in smoke:cli. + * the validate / CI ordering guarantees this. `test-servers/build` is rebuilt on + * every run, as in smoke:cli — see `scripts/lib/ensure-test-servers.mjs` for why + * presence isn't freshness. This smoke is the one that found that out: a + * `v2/main` merge touching `preset-registry.ts` made it report the dedicated + * app-origin path as broken when it was really driving the pre-merge fixture. */ import { existsSync } from "node:fs";