fix(auth): revoke every issuer-bound grant, not just the active one (#2144)

Copilot review round 3.

`clear(serverUrl)` deletes EVERY `byIssuer` slot, but revocation read only the
context-free (active-issuer) token. A server that had authorized against
issuers A and B therefore revoked B, then destroyed the local record of A while
A's grant stayed live at its authorization server — the same leak this feature
exists to close, one level down.

- `OAuthStorage.listIssuers(serverUrl)` is the new seam (one implementation:
  every backend extends `OAuthStorageBase`). `collectGrants` walks it plus the
  ctx-less read, deduping by token, so every grant the clear will delete is
  covered.
- Metadata is cached once per server, not per issuer, so a grant bound to an
  issuer the cached document does not describe cannot be revoked: sending its
  token to that endpoint would hand a credential to a server that never minted
  it. That grant is reported as failed — dropped unrevoked — rather than
  silently discarded or misdirected.
- `aggregateOutcomes` gives a failure precedence over another grant's success,
  so one live grant cannot hide behind another's 200. Exported for its own
  test, since `computeOutcome` returns early on the empty case.

Also from that round:

- The fixture's /oauth/revoke now verifies token ownership (RFC 7009 §2.1).
  Access tokens record their owning `client_id`; a token belonging to another
  client is left alone and still answered 200 (§2.2 — the response must not
  tell one client whether another's token exists). New e2e case proves a
  second registered client cannot revoke the first's grant.
- The TUI rendered the revocation-failure note in cyan, the informational
  tone. It is a partial success — the local clear really happened — so it is
  not an `error` status, but the grant may still be live and cyan understated
  that. `AuthTab` takes an `oauthMessageTone`; the message says so explicitly.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0177mPHAdECD18nLLCTwR5rh
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-08-28 02:40:28 -04:00
commit 781aa69d19
2 changed files with 479 additions and 52 deletions

View file

@ -1407,9 +1407,18 @@ describe("App (mid-session auth lifecycle events)", () => {
});
const r = await mount(oneHttp());
await press(r, ["a", "s"]);
// The detail is what identifies the failure; the tone the message renders
// in is asserted against `AuthTab` directly, where the branch lives.
await expectFrame(r, "unreachable");
});
it("says nothing when there was nothing to revoke", async () => {
const r = await mount(oneHttp());
await press(r, ["a", "s"]);
await waitUntil(() => h.clientSpies.clearOAuthTokens.mock.calls.length > 0);
expect(r.lastFrame() ?? "").not.toContain("authorization server failed");
});
const stepUpChallenge = {
reason: "insufficient_scope" as const,
requiredScopes: ["env:read"],

View file

@ -100,6 +100,35 @@ describe("AuthTab", () => {
);
});
// #2144 — a revocation failure is a *partial* success: the local state really
// was cleared, so it is not an `error` status, but the grant may still be
// live at the authorization server and the informational tone understates
// that. Both tones are exercised so neither branch can rot.
it("renders an idle message in the warning tone when asked", () => {
const { lastFrame } = render(
<AuthTab
{...baseProps}
inspectorClient={null}
oauthStatus="idle"
oauthMessage="Cleared locally, but revoking failed."
oauthMessageTone="warning"
/>,
);
expect(lastFrame() ?? "").toContain("Cleared locally");
});
it("renders an idle message in the default informational tone", () => {
const { lastFrame } = render(
<AuthTab
{...baseProps}
inspectorClient={null}
oauthStatus="idle"
oauthMessage="Stored OAuth state cleared."
/>,
);
expect(lastFrame() ?? "").toContain("Stored OAuth state cleared.");
});
it("renders OAuth details from getOAuthState", async () => {
const { client } = makeClient(sampleOAuthState);
const { lastFrame } = render(