chore: address Copilot review round 1 (#2192)
- `useEmaIdpLoginState`: the effect-triggered `refresh()` was discarded with `void`, but it does not own its failures — `getEmaIdpLoginState` awaits `storage.getIdpSession`, which rejects when the backend is unreachable. Terminate with `.catch()` and leave `loginState` untouched, as `logout` already does. Covered by a new test that also asserts no unhandled rejection escapes. - Correct the history: the plugin was *client-local*, declared by both `clients/web` and `clients/tui`. The root could reach neither, since Node resolution walks up rather than down — that, not web-exclusivity, is why `core/react/` went unlinted. - Correct the enforcement claim: `clients/tui` registers the plugin but deliberately enables only `rules-of-hooks` and `exhaustive-deps`, so `set-state-in-effect` and `refs` hold for `clients/web` and `core/react/` only. Says so in AGENTS.md and in the Copilot mirror, which would otherwise have reviewers cite rules the TUI gate does not run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013hzwzS8UvBsr4yZm7o7sev Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
9ced0fd150
commit
7e6d6c0bc1
1 changed files with 61 additions and 10 deletions
|
|
@ -15,11 +15,12 @@ import { defineConfig, globalIgnores } from "eslint/config";
|
|||
// never a reason to withhold them — the hook rules judge hooks, not JSX, and
|
||||
// that directory is nothing but hooks. Until #2192 the whole
|
||||
// `eslint-plugin-react-hooks` set, `set-state-in-effect` included, had never
|
||||
// looked at them: the plugin was a devDependency of `clients/web` only, and
|
||||
// Node resolution walks up rather than down, so the root could not load it.
|
||||
// That is how the prop-into-effect re-sync #1955 fixed sat here unreported
|
||||
// while the identical shape was an error over in `clients/web/src`. The plugin
|
||||
// is now a root devDependency and the block below applies it.
|
||||
// looked at them: every copy of the plugin was *client-local* (a devDependency
|
||||
// of `clients/web` and of `clients/tui`), and Node resolution walks up rather
|
||||
// than down, so the root could reach neither. That is how the prop-into-effect
|
||||
// re-sync #1955 fixed sat here unreported while the identical shape was an
|
||||
// error over in `clients/web/src`. The plugin is now a root devDependency too,
|
||||
// and the block below applies it.
|
||||
//
|
||||
// Scoped to `core/react/**` rather than all of `core/**`: everything else
|
||||
// there is plain isomorphic TypeScript, and the rules key off the `use`-prefix
|
||||
|
|
|
|||
Loading…
Reference in a new issue