From 7f1b8def04b41c1336718b91c307d38b03115cb4 Mon Sep 17 00:00:00 2001 From: cliffhall Date: Sat, 5 Sep 2026 17:32:58 -0400 Subject: [PATCH] Review round 5: scope the opening section's closer to the connecting branch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Copilot, accepted. Round 4 split the trigger into two branches and fixed the closing section, but left the paragraph that ends the opening section speaking for both — asserting a real transport and a protocol era for the build-only case that lines 28-31 had just established has neither. Scoped explicitly: "In the connecting case …" keeps the transport and protocol-era guidance, "In the build-only case …" says that guidance does not apply and names what is actually wanted from `test-servers` there — how to build the fixture, and why a stale build keeps serving old code. Re-measured: 100% / 100% hand-off, 63/63 first-move at 100%, full suite at RUNS=5. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_01EQVdemwgUhh45yzeaRSLhW Signed-off-by: cliffhall --- .claude/skills/testing/SKILL.md | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.claude/skills/testing/SKILL.md b/.claude/skills/testing/SKILL.md index c64dad41..5207db6e 100644 --- a/.claude/skills/testing/SKILL.md +++ b/.claude/skills/testing/SKILL.md @@ -47,11 +47,14 @@ They sit there for the node env and the 30s timeout, not because they connect placement is the project manifest, so it cannot also be the fixture trigger. Ask what the test *does*, not where it lives. -When it does apply, the test drives a **real server over a real transport, never -a mock**, and picking the fixture, building it, and connecting with the right -protocol era is a procedure this skill does not carry. Writing one without -`test-servers` means hand-rolling a fixture that already exists, or mocking the -thing the tier exists to avoid mocking. +**In the connecting case**, the test drives a **real server over a real +transport, never a mock**, and picking the fixture, building it, and connecting +with the right protocol era is a procedure this skill does not carry. Writing +one without `test-servers` means hand-rolling a fixture that already exists, or +mocking the thing the tier exists to avoid mocking. **In the build-only case**, +none of the transport or protocol-era guidance applies — what you need from +`test-servers` is how to build the fixture and why a stale build keeps serving +old code. ## Where the test file goes