refactor(core): apply v1.5-port cleanups deferred from #1306 (#1316)

* refactor(core): apply v1.5-port cleanups deferred from #1306

Addresses issue #1309 — five small, mechanical cleanups deferred from the
v1.5 runtime port:

1. Collapse BrowserOAuthStorage / NodeOAuthStorage / RemoteOAuthStorage
   onto a shared OAuthStorageBase. Three ~130-line duplicates become
   thin adapter wrappers; behavior + public API unchanged.
2. Re-enable erasableSyntaxOnly in tsconfig.app.json by rewriting the
   seven (plus two the issue missed in sampling/elicitation create-
   message) parameter-property constructors as explicit field + assign.
3. Route the lone console.error in inspectorClient.ts through this.logger.
4. Replace `${Date.now()}-${Math.random()}` with crypto.randomUUID() at
   the five local-only ID sites (message tracking + sampling/elicit).
5. Pin the remote-server hono app generic at new Hono<Env>() and drop
   the streamSSE cast. Root cause of the cast was an unresolved hono
   subpath: the tsconfig "hono/*" wildcard didn't honor the exports
   map, so hono/streaming leaked to the root-hoisted hono@4.12.12 while
   hono itself resolved to clients/web/hono@4.12.18. Replaced the
   wildcard with an explicit hono/streaming entry in both tsconfig.app
   and tsconfig.test, removing the package-identity mismatch.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor(core): address #1316 PR review feedback

- Drop the stranded no-op getServerState() read at the top of
  clearClientInformation in OAuthStorageBase (carried over verbatim
  from the three originals).
- Drop the crypto.randomUUID() guard at the task-ID site so all
  six in-scope sites are consistent; the fallback branch was dead
  code on every supported runtime.
- Remove the residual `c as Context` cast at the streamSSE call site
  in core/mcp/remote/node/server.ts — once both hono imports
  resolve to the same package the route-typed Context flows through
  to streamSSE with no cast at all.
- Move the new `options` / `config` field declarations in
  RemoteClientTransport up with the rest of the field block, matching
  the layout used by the other five rewritten classes in this PR.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

core/mcp/inspectorClient.ts

@@ -174,12 +174,14 @@ export class InspectorClient extends InspectorClientEventTarget {
   private effectiveAuthFetch: typeof fetch;
   // Session ID (for OAuth state and saveSession event; persistence is in FetchRequestLogState)
   private sessionId?: string;
+  private transportConfig: MCPServerConfig;
 
   constructor(
-    private transportConfig: MCPServerConfig,
+    transportConfig: MCPServerConfig,
     options: InspectorClientOptions,
   ) {
     super();
+    this.transportConfig = transportConfig;
     // Extract environment components
     this.transportClientFactory = options.environment.transport;
     this.fetchFn = options.environment.fetch;
@@ -309,7 +311,7 @@ export class InspectorClient extends InspectorClientEventTarget {
     return {
       trackRequest: (message: JSONRPCRequest) => {
         const entry: MessageEntry = {
-          id: `${Date.now()}-${Math.random()}`,
+          id: crypto.randomUUID(),
           timestamp: new Date(),
           direction: "request",
           message,
@@ -320,7 +322,7 @@ export class InspectorClient extends InspectorClientEventTarget {
         message: JSONRPCResultResponse | JSONRPCErrorResponse,
       ) => {
         const entry: MessageEntry = {
-          id: `${Date.now()}-${Math.random()}`,
+          id: crypto.randomUUID(),
           timestamp: new Date(),
           direction: "response",
           message,
@@ -329,7 +331,7 @@ export class InspectorClient extends InspectorClientEventTarget {
       },
       trackNotification: (message: JSONRPCNotification) => {
         const entry: MessageEntry = {
-          id: `${Date.now()}-${Math.random()}`,
+          id: crypto.randomUUID(),
           timestamp: new Date(),
           direction: "notification",
           message,
@@ -415,10 +417,7 @@ export class InspectorClient extends InspectorClientEventTarget {
     statusMessage?: string;
     pollInterval?: number;
   }): ReceiverTaskRecord {
-    const taskId =
-      typeof crypto !== "undefined" && crypto.randomUUID
-        ? crypto.randomUUID()
-        : `task-${Date.now()}-${Math.random().toString(36).slice(2, 11)}`;
+    const taskId = crypto.randomUUID();
     const ttlMs =
       opts.ttl ??
       (typeof this.receiverTaskTtlMs === "function"
@@ -1962,7 +1961,10 @@ export class InspectorClient extends InspectorClientEventTarget {
       });
     } catch (error) {
       // Log but don't throw - roots were updated locally even if notification failed
-      console.error("Failed to send roots/list_changed notification:", error);
+      this.logger.error(
+        { error },
+        "Failed to send roots/list_changed notification",
+      );
     }
   }