* refactor(core): apply v1.5-port cleanups deferred from #1306 Addresses issue #1309 — five small, mechanical cleanups deferred from the v1.5 runtime port: 1. Collapse BrowserOAuthStorage / NodeOAuthStorage / RemoteOAuthStorage onto a shared OAuthStorageBase. Three ~130-line duplicates become thin adapter wrappers; behavior + public API unchanged. 2. Re-enable erasableSyntaxOnly in tsconfig.app.json by rewriting the seven (plus two the issue missed in sampling/elicitation create- message) parameter-property constructors as explicit field + assign. 3. Route the lone console.error in inspectorClient.ts through this.logger. 4. Replace `${Date.now()}-${Math.random()}` with crypto.randomUUID() at the five local-only ID sites (message tracking + sampling/elicit). 5. Pin the remote-server hono app generic at new Hono<Env>() and drop the streamSSE cast. Root cause of the cast was an unresolved hono subpath: the tsconfig "hono/*" wildcard didn't honor the exports map, so hono/streaming leaked to the root-hoisted hono@4.12.12 while hono itself resolved to clients/web/hono@4.12.18. Replaced the wildcard with an explicit hono/streaming entry in both tsconfig.app and tsconfig.test, removing the package-identity mismatch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(core): address #1316 PR review feedback - Drop the stranded no-op getServerState() read at the top of clearClientInformation in OAuthStorageBase (carried over verbatim from the three originals). - Drop the crypto.randomUUID() guard at the task-ID site so all six in-scope sites are consistent; the fallback branch was dead code on every supported runtime. - Remove the residual `c as Context` cast at the streamSSE call site in core/mcp/remote/node/server.ts — once both hono imports resolve to the same package the route-typed Context flows through to streamSSE with no cast at all. - Move the new `options` / `config` field declarations in RemoteClientTransport up with the rest of the field block, matching the layout used by the other five rewritten classes in this PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
88b55b093b
commit
82269e78cb
1 changed files with 236 additions and 449 deletions
|
|
@ -17,7 +17,7 @@ import {
|
|||
} from "../../../storage/store-io.js";
|
||||
import type { LogEvent } from "pino";
|
||||
import { Hono } from "hono";
|
||||
import type { Context, Next } from "hono";
|
||||
import type { Context, Env, Next } from "hono";
|
||||
import { streamSSE } from "hono/streaming";
|
||||
import { createTransportNode } from "../../node/transport.js";
|
||||
import type { RemoteConnectRequest, RemoteSendRequest } from "../types.js";
|
||||
|
|
@ -277,7 +277,7 @@ export function createRemoteApp(
|
|||
process.env[API_SERVER_ENV_VARS.AUTH_TOKEN] ||
|
||||
randomBytes(32).toString("hex");
|
||||
|
||||
const app = new Hono();
|
||||
const app = new Hono<Env>();
|
||||
const sessions = new Map<string, RemoteSession>();
|
||||
const { logger: fileLogger, allowedOrigins } = options;
|
||||
const storageDir = options.storageDir ?? getDefaultStorageDir();
|
||||
|
|
@ -453,9 +453,7 @@ export function createRemoteApp(
|
|||
return c.json({ error: "Session not found" }, 404);
|
||||
}
|
||||
|
||||
// hono's streamSSE generic typing has tightened since v1.5; cast the
|
||||
// route-typed Context down to the broader Context shape it expects.
|
||||
return streamSSE(c as unknown as Parameters<typeof streamSSE>[0], async (stream) => {
|
||||
return streamSSE(c, async (stream) => {
|
||||
session.setEventConsumer((event) => {
|
||||
const data = JSON.stringify(event);
|
||||
void stream.writeSSE({
|
||||
|
|
|
|||
Loading…
Reference in a new issue