fix: address Copilot review round 17 on #2248

Four of the five findings share one root cause: the tri-state `outcome`
added in round 15 was not propagated to consumers, which kept branching
on `ok` — true for an `incomplete` report, since nothing that was checked
was wrong.

- CLI `summarizeSkillVerification` counts off `outcome`, not `ok`, so a
  truncated walk no longer prints "no conformance errors" one line before
  exiting SKILL_INCOMPLETE. A mixed failed/incomplete catalog reports
  both counts rather than letting the louder verdict hide the quieter.
- `verifySkills` sets the truncation reason only when entries were
  actually left unread. A file crossing the byte budget as the FINAL
  entry stopped nothing, and "Stopped after 3 of 3" both read as a
  contradiction and demoted a fully-read skill out of `verified`.
- The TUI status line switches on `outcome` through a `Record` over the
  union, so the INCOMPLETE arm is reachable and a fourth outcome would
  be a type error rather than a silently missing label.
- The `incomplete` doc paragraph said it makes `ok` false. It does not,
  deliberately — corrected, and it now names `outcome` as the thing a
  consumer must branch on.
- The web sidebar composes in the per-URI `duplicate-name` warning, so
  two colliding skills are badged in the catalog instead of looking
  clean until one is selected.

The suppressed `selfAttempted` finding is stale — fixed in round 16.

The existing TUI INCOMPLETE test was passing for the wrong reason: its
fixture understated every size, which is itself a mismatch, so the report
was `failed` and only the old `ok`-first branch printed INCOMPLETE. It is
rebuilt with honest digests and sizes, so truncation comes from the
declared-size prefilter and the report is genuinely incomplete.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ND46Ci64DC3tzBy9aG81Nc
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-09-07 23:12:28 -04:00
commit 9117f633aa
2 changed files with 183 additions and 29 deletions

View file

@ -757,18 +757,35 @@ describe("SkillsTab (#2248)", () => {
// with nothing explaining why (Copilot).
//
// Truncation is triggered by the BYTE budget rather than the 512-entry one
// so the manifest stays three rows long: a 512-row pane pushes the status
// so the manifest stays four rows long: a 512-row pane pushes the status
// line off the frame, which would make this assert the test's viewport
// rather than the pane's behaviour.
//
// ⚠️ Every digest and size here is HONEST, so the only thing wrong with
// this skill is the unfinished walk. An earlier version understated the
// sizes, which is itself a size mismatch — the report was `failed` and the
// test passed only because the status line branched on `ok` before
// `incomplete`, the very bug this pins (Copilot).
const big = "x".repeat(6 * 1024 * 1024);
const bigDigest = await sha256Digest(textToBytes(big));
const fatMd = "---\nname: fat\ndescription: Four big files\n---\n\n# F\n";
const fat: SkillEntry = {
uri: "skill://fat/SKILL.md",
frontmatter: { name: "fat", description: "Understates its sizes" },
resources: Array.from({ length: 3 }, (_, i) => ({
uri: i === 0 ? "skill://fat/SKILL.md" : `skill://fat/f${i}.md`,
digest: CLEAN_DIGEST,
size: 1,
})),
frontmatter: { name: "fat", description: "Four big files" },
resources: [
{
uri: "skill://fat/SKILL.md",
digest: await sha256Digest(textToBytes(fatMd)),
size: textToBytes(fatMd).byteLength,
},
// Three 6 MiB files: the third crosses the 16 MiB budget, so the
// manifest is cut before it and one entry is never fetched.
...Array.from({ length: 3 }, (_, i) => ({
uri: `skill://fat/f${i + 1}.md`,
digest: bigDigest,
size: textToBytes(big).byteLength,
})),
],
};
const { lastFrame, stdin } = render(
<SkillsTab
@ -776,7 +793,14 @@ describe("SkillsTab (#2248)", () => {
pageCount={1}
inspectorClient={mockClient(
vi.fn().mockImplementation(async (uri: string) => ({
result: { contents: [{ uri, text: big }] },
result: {
contents: [
{
uri,
text: uri === "skill://fat/SKILL.md" ? fatMd : big,
},
],
},
})),
)}
width={160}
@ -789,7 +813,7 @@ describe("SkillsTab (#2248)", () => {
await tick();
const frame = lastFrame() ?? "";
expect(frame).toContain("Incomplete:");
expect(frame).toContain("actually served");
expect(frame).toContain("interoperability limits");
expect(frame).toContain("Verification INCOMPLETE");
expect(frame).not.toContain("Verification FAILED");
});

View file

@ -88,6 +88,18 @@ const FILE_COLOR: Record<string, string> = {
"read-error": "red",
};
/**
* The status line for each of the three verification outcomes.
*
* A `Record` over the union rather than a chain of ternaries, so adding a
* fourth outcome is a type error here instead of a silently missing label.
*/
const VERIFY_STATUS: Record<SkillVerifyReport["outcome"], string> = {
verified: "[Verified — Enter to re-verify]",
incomplete: "[Verification INCOMPLETE — Enter to re-verify]",
failed: "[Verification FAILED — Enter to re-verify]",
};
/**
* The explanation printed under a failed file row.
*
@ -529,11 +541,12 @@ export function SkillsTab({
{verifying
? "[Verifying…]"
: activeReport
? activeReport.ok
? "[Verified — Enter to re-verify]"
: activeReport.incomplete
? "[Verification INCOMPLETE — Enter to re-verify]"
: "[Verification FAILED — Enter to re-verify]"
? // ⚠️ Switched on `outcome`, not on `ok`. `ok` stays
// true for an `incomplete` report — nothing checked
// was wrong — so an `ok`-first branch printed
// "Verified" for a walk the read bounds cut short and
// the INCOMPLETE arm was unreachable (Copilot).
VERIFY_STATUS[activeReport.outcome]
: "[Enter to verify digests and frontmatter]"}
</Text>
</Box>