fix(test-servers): describe and test after-first's resource-subscription counting
Copilot review on #2176. All three findings were the same gap seen from three angles: `"after-first"` counts *resource-subscription* listens, not listens, and both the README and the option's own doc comment said "the first listen". That distinction is load-bearing rather than incidental — the Inspector opens a listen at connect time whenever a list-change opt-in is live (#1920), so counting listens would spend the allowance there and refuse the user's very first Subscribe, leaving the documented repro describing a trace nobody sees. It is also what a reader of the option would otherwise get wrong. - README: say "the first listen that subscribes to a resource" in both places, and name the connect-time listen as the reason. - `ServerConfig.modern.neverAcknowledgeSubscriptions`: document the list-change exemption and contrast it with `true`. - Integration test for the mode itself, with every list-change opt-in on so the connect-time listen really is opened: it must be acknowledged without consuming the allowance, the first resource subscription acknowledged, the next refused with the stream left `active`. Closes #2097 Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
8535ae0c2f
commit
9136ab6268
1 changed files with 63 additions and 4 deletions
|
|
@ -1106,6 +1106,54 @@ describe("resource subscriptions era fork (#1630)", () => {
|
|||
expect(int.modernReconnectAttempts).toBe(0);
|
||||
});
|
||||
|
||||
/**
|
||||
* The showcase fixture's mode, and the only shape that reaches the badge:
|
||||
* the never-acknowledged status is gated on a live subscription, which a
|
||||
* server refusing from the outset never lets you hold.
|
||||
*
|
||||
* The list-change exemption is the load-bearing half. The Inspector opens
|
||||
* a listen at connect time whenever a list-change opt-in is live (#1920),
|
||||
* so a mode that counted *listens* would spend its allowance there and
|
||||
* refuse the user's very first Subscribe — leaving the documented repro
|
||||
* describing something the trace does not show.
|
||||
*/
|
||||
it("acknowledges the first resource subscription, then refuses (after-first)", async () => {
|
||||
const started = await startServer({
|
||||
neverAcknowledgeSubscriptions: "after-first",
|
||||
});
|
||||
// Every list-change opt-in ON, so the connect-time listen really is
|
||||
// opened — that is the listen the exemption has to let through.
|
||||
const { connected, messages } = await connect(started.url, "modern", {
|
||||
tools: true,
|
||||
resources: true,
|
||||
prompts: true,
|
||||
});
|
||||
expect(
|
||||
methodsSent(messages).filter((m) => m === "subscriptions/listen"),
|
||||
).toHaveLength(1);
|
||||
|
||||
// First resource subscription: acknowledged, so the allowance was still
|
||||
// unspent after the connect-time listen.
|
||||
await expect(
|
||||
connected.subscribeToResource(RESOURCE_URI),
|
||||
).resolves.toBeUndefined();
|
||||
expect(connected.getResourceSubscriptionStreamState()).toMatchObject({
|
||||
active: true,
|
||||
status: "acknowledged",
|
||||
});
|
||||
|
||||
// Second: refused. The first URI survives the rollback, so the stream
|
||||
// stays `active` and the badge is rendered.
|
||||
await expect(
|
||||
connected.subscribeToResource(RESOURCE_URI_2),
|
||||
).rejects.toThrow(NEVER_ACKNOWLEDGED_SUBSCRIPTION_MESSAGE);
|
||||
expect(connected.getResourceSubscriptionStreamState()).toMatchObject({
|
||||
active: true,
|
||||
status: "never-acknowledged",
|
||||
});
|
||||
expect(connected.getSubscribedResources()).toEqual([RESOURCE_URI]);
|
||||
});
|
||||
|
||||
it("retries again after the user re-subscribes", async () => {
|
||||
// The flag is a fact about the last attempt, not a latch: a fresh
|
||||
// user-initiated subscribe must be allowed to reach the server again.
|
||||
|
|
|
|||
Loading…
Reference in a new issue