modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: address Copilot review round 21 — seed a nested object's own union branch

Browse source 
collectSchemaDefaults recursed only when a nested object declared `properties`
directly, so one keeping its fields on a composition branch was skipped — while
SchemaForm rendered that branch and displayed its read-only discriminator. The
constant was shown and never submitted, and the server rejected the call. The
recursion now gates on declaresAnyFields.

Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-08-26 07:41:22 -04:00
commit 92e485ab82
1 changed files with 40 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
clients/web/src/utils/jsonUtils.ts
View file

@ -4,6 +4,7 @@ import {
} from "@inspector/core/json/nullableUnion.js";
import {
branchAcceptsValues,
declaresAnyFields,
resolveRootUnion,
selectBranchIndex,
} from "@inspector/core/json/rootUnion.js";
@ -176,7 +177,14 @@ export function collectSchemaDefaults(
seed(fieldName, fieldSchema.const);
} else if (fieldSchema.default !== undefined) {
seed(fieldName, fieldSchema.default);
} else if (fieldSchema.type === "object" && fieldSchema.properties) {
} else if (
fieldSchema.type === "object" &&
// Not `fieldSchema.properties`: a nested object can keep its fields on a
// composition branch too, and `SchemaForm` renders that branch — so
// skipping it here would leave its read-only discriminator displayed but
// never submitted, and the server would reject the call (#2123).
declaresAnyFields(fieldSchema)
) {
const nested = collectSchemaDefaults(fieldSchema);
if (Object.keys(nested).length > 0) {
seed(fieldName, nested);