chore: make the workflow skills model-invocable
`disable-model-invocation: true` does not merely make a skill prefer `/name` — the model cannot invoke it at all, and its description is absent from the skill listing. So "create a PR for #2163", which is how that work actually starts, could never reach `pr-flow`. The original rationale ("procedures with side effects we'd invoke by name anyway") conflates invoking a skill, which only loads instructions, with performing the procedure it describes. Flipped `pr-flow`, `pre-push-gate`, `board-ops` and `test-servers` to model-invocable. `user-invocable` is an independent axis, so this is purely additive — every `/name` still works. `issue-create`, `issue-triage` and `release` stay deliberate. `board-ops` is in the set because `pr-flow` and `issue-create` delegate their card steps to it: a pointer from a model-invocable skill to a manual-only one is a dead end for the model. Costs weighed: the listing share goes 1,199 → 2,256 of 4,000, and a spurious load costs ~250 characters where a missed one costs a wrong base branch or an unsigned commit. The rules stay resident in AGENTS.md either way — this improves the odds of getting the procedure too, it does not become the guarantee. Eval cases committed for all four, measured at RUNS=3: pre-push-gate, board-ops and test-servers 5/5; pr-flow 4/5, with "take it through to a pull request" at 100% and the Copilot-review case borderline. Three initial cases were replaced rather than tuned green: their answers are resident in AGENTS.md, so the model answering without the skill is correct behaviour, not a miss — the rule this file already records about what makes a valid trigger case. AGENTS.md's maintenance rule now says to default to `false` and explains why, so the advice this change walks back does not get re-applied. Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
67abdf96b4
commit
94a71f48bc
2 changed files with 117 additions and 18 deletions
|
|
@ -1,7 +1,7 @@
|
|||
---
|
||||
name: pr-flow
|
||||
description: Take an issue through to a merged PR — branch naming, the DCO signoff, screenshots, opening the PR against the right base, requesting a Copilot review, responding to review rounds, and closing out (manual close plus Done).
|
||||
disable-model-invocation: true
|
||||
description: Take an issue through to a merged PR in this repo, and what to do at each step. Use when asked to open, create or submit a PR; when a DCO or signoff check fails; when requesting a Copilot review or responding to review comments; when naming a branch; when attaching screenshots to a PR; or when closing out after a merge.
|
||||
disable-model-invocation: false
|
||||
---
|
||||
|
||||
# PR flow
|
||||
|
|
|
|||
22
.claude/skills/pr-flow/evals/evals.json
Normal file
22
.claude/skills/pr-flow/evals/evals.json
Normal file
|
|
@ -0,0 +1,22 @@
|
|||
[
|
||||
{
|
||||
"prompt": "I've finished the fix for issue 2071. Take it through to a pull request.",
|
||||
"expect": "pr-flow"
|
||||
},
|
||||
{
|
||||
"prompt": "How do I get Copilot to review a PR in this repo?",
|
||||
"expect": "pr-flow"
|
||||
},
|
||||
{
|
||||
"prompt": "The DCO check is red on my branch. How do I fix the commits I already pushed?",
|
||||
"expect": "pr-flow"
|
||||
},
|
||||
{
|
||||
"prompt": "What does this regex match? /^[a-z]+$/",
|
||||
"expect": null
|
||||
},
|
||||
{
|
||||
"prompt": "Translate 'good morning' into Spanish.",
|
||||
"expect": null
|
||||
}
|
||||
]
|
||||
Loading…
Reference in a new issue