From 995c06948cb6df9cdc89831ddbe0a4be545ce161 Mon Sep 17 00:00:00 2001 From: cliffhall Date: Sat, 18 Apr 2026 19:13:22 -0400 Subject: [PATCH] Address PR #1214 review nits - Hoist previewUri() to a const in ResourceTemplatePanel to avoid duplicate computation - Include resource.title in subscriptions search filter for consistency with resources and templates filters Co-Authored-By: Claude Opus 4.6 (1M context) --- .../components/groups/ResourceControls/ResourceControls.tsx | 1 + .../groups/ResourceTemplatePanel/ResourceTemplatePanel.tsx | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/clients/web/src/components/groups/ResourceControls/ResourceControls.tsx b/clients/web/src/components/groups/ResourceControls/ResourceControls.tsx index 3ee2640a..7e612064 100644 --- a/clients/web/src/components/groups/ResourceControls/ResourceControls.tsx +++ b/clients/web/src/components/groups/ResourceControls/ResourceControls.tsx @@ -70,6 +70,7 @@ export function ResourceControls({ const filteredSubscriptions = subscriptions.filter( (s) => s.resource.name.toLowerCase().includes(query) || + (s.resource.title?.toLowerCase().includes(query) ?? false) || s.resource.uri.toLowerCase().includes(query), ); diff --git a/clients/web/src/components/groups/ResourceTemplatePanel/ResourceTemplatePanel.tsx b/clients/web/src/components/groups/ResourceTemplatePanel/ResourceTemplatePanel.tsx index 6e56fd11..b7e76e30 100644 --- a/clients/web/src/components/groups/ResourceTemplatePanel/ResourceTemplatePanel.tsx +++ b/clients/web/src/components/groups/ResourceTemplatePanel/ResourceTemplatePanel.tsx @@ -91,13 +91,15 @@ export function ResourceTemplatePanel({ onReadResource(resolveUri(uriTemplate, variables)); } + const preview = previewUri(uriTemplate, variables); + return ( {title ?? name} Template - {previewUri(uriTemplate, variables)} - + {preview} + {description && {description}}