modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

docs(web): describe the accepted subset, not "parses as a source expression"

Browse source 
Review catch: `'unsafe-eval'` *is* a valid CSP source expression, so saying
the filter drops entries that "don't parse as a source expression" was both
wrong and a rerun of the misconception this PR set out to fix — and it
contradicted the NOTE two paragraphs down.

The doc now names the accepted subset (`scheme://host[:port][/path]`, a bare
or wildcard host, a scheme such as `data:`, and `*`) and says explicitly that
a CSP keyword is a valid source expression these origin-list fields simply
cannot express. The now-duplicated half of the third paragraph is trimmed.

Comment-only; the warning string and tests are unchanged.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UL9retfvAXRgvi6EWk4SY4
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-08-24 01:20:18 -04:00
commit 99f8ccde18
1 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

22
clients/web/src/utils/sandbox-csp.ts
View file

@ -41,11 +41,15 @@ const CSP_KEYS = exhaustiveCspKeys([
/** /**
* Filter an app-supplied {@link McpUiResourceCsp} down to the entries the host * Filter an app-supplied {@link McpUiResourceCsp} down to the entries the host
* will actually enforce. Entries that don't parse as a source expression are * will actually enforce. The accepted subset is the origin forms
* dropped (and warned), and the resulting object contains only keys with at * {@link SAFE_CSP_SOURCE} matches — `scheme://host[:port][/path]`, a bare or
* least one accepted source. The return value is what the host echoes back to * wildcard host, a scheme such as `data:`, and `*`. Anything outside it is
* the view via `hostCapabilities.sandbox.csp` so the app sees what was granted, * dropped (and warned) — including a CSP keyword like `'unsafe-eval'`, which
* not what it asked for. * is a perfectly valid source expression in CSP but not something these
* origin-list fields can express. The resulting object contains only keys with
* at least one accepted source, and is what the host echoes back to the view
* via `hostCapabilities.sandbox.csp` so the app sees what was granted, not what
* it asked for.
* *
* NOTE: this screens each source for *injection safety* only — it does NOT * NOTE: this screens each source for *injection safety* only — it does NOT
* bound the *breadth* of a grant. A bare `*` (and a scheme-wildcard host) is a * bound the *breadth* of a grant. A bare `*` (and a scheme-wildcard host) is a
@ -59,11 +63,9 @@ const CSP_KEYS = exhaustiveCspKeys([
* *
* The drop warning is worded accordingly: it names the field the entry came * The drop warning is worded accordingly: it names the field the entry came
* from and states the shape expected, and makes no claim about the *safety* of * from and states the shape expected, and makes no claim about the *safety* of
* the value. These four fields are origin lists, so the usual cause of a drop * the value. Saying "unsafe" instead read as a security verdict this check
* is an entry that simply isn't an origin — a CSP keyword such as * never makes, and sent #2012 chasing an XSS regression that wasn't one, when
* `'unsafe-eval'` has no field in the contract to be requested through. Saying * the entry had merely been the wrong kind of thing for the field (#2064).
* "unsafe" instead read as a security verdict this check never makes, and sent
* #2012 chasing an XSS regression that wasn't one (#2064).
*/ */
export function approveCspSources( export function approveCspSources(
csp: McpUiResourceCsp | undefined, csp: McpUiResourceCsp | undefined,