feat: Skills extension phase 3 — CLI, TUI, directory reads, frontmatter check
Closes #2248. Completes SEP-2640 support across all three clients, and closes the one obligation #2234 deliberately left open. - `checkSkillFrontmatterMatch` compares a served SKILL.md's own YAML frontmatter against the entry the listing advertised, field by field. No digest can cover this: a digest is taken over the bytes the server served, so it proves the file was not altered in transit and says nothing about whether the listing described it honestly. Needs a real YAML parser; `yaml` was already a root dependency, so this adds no package — but it does newly put it on core/'s import graph, hence the three bundler `external` lists. - `resources/directory/read`: result schemas defined against the normative text, `InspectorClient.readResourceDirectory`, a Directory section on the Skills screen, and `--method resources/directory/read` in the CLI. The client refuses the call locally when the server did not declare `directoryRead`, which is the SEP's MUST NOT. A child the directory lists but the entry does not is marked `not listed` rather than merged into the manifest — the SEP calls a directory result a live observation and forbids treating it as extending the manifest. - CLI: `skills/list`, `skills/get` and `resources/directory/read`, plus `--verify` — one NDJSON report per skill, a summary on stderr, exit 7 on a violation. Reads are sequential; a conforming manifest may declare 512 entries. - TUI: a Skills pane, shown only when the server declares the extension. Each row carries its conformance verdict as a glyph as well as a colour, since the pane is read over ssh and through script(1). Enter verifies. - `verifySkills` re-throws `AuthRecoveryRequiredError` rather than recording it per file: it says the session's authorization expired, so absorbing it would report N identical read failures and swallow the error the TUI and the web commands key off to reauthorize. Two open questions settled, both in code comments where they will be found: `skills/get` carries no caching attributes because SEP-2640 leaves the question open in as many words, so requiring them would fail a conforming server; and there is no `PagedSkillsState` because every consumer of this list is a whole-catalog verdict — computed over page one of three, "this server's skills conform" is not merely partial but wrong. The fixture grows two skills, both for checks that were otherwise undemonstrable: `lying-listing` (listing and file disagree, digest still verifies) and `stale-manifest` (serves a file its manifest does not declare). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ND46Ci64DC3tzBy9aG81Nc Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall
parent
219a08e1b5
commit
9a8488681e
3 changed files with 4750 additions and 191 deletions
|
|
@ -24,6 +24,8 @@ const h = vi.hoisted(() => {
|
|||
resources: unknown[];
|
||||
resourceTemplates: unknown[];
|
||||
prompts: unknown[];
|
||||
skills: unknown[];
|
||||
skillsExtension: { directoryRead: boolean } | undefined;
|
||||
messages: unknown[];
|
||||
fetchRequests: unknown[];
|
||||
stderrLogs: unknown[];
|
||||
|
|
@ -39,6 +41,8 @@ const h = vi.hoisted(() => {
|
|||
resources: [],
|
||||
resourceTemplates: [],
|
||||
prompts: [],
|
||||
skills: [],
|
||||
skillsExtension: undefined as { directoryRead: boolean } | undefined,
|
||||
messages: [],
|
||||
fetchRequests: [],
|
||||
stderrLogs: [],
|
||||
|
|
@ -160,6 +164,10 @@ const h = vi.hoisted(() => {
|
|||
| "sse"
|
||||
| "streamable-http",
|
||||
);
|
||||
// The Skills tab is gated on a SERVER declaration, so the default here is
|
||||
// "not declared" — the tab is hidden unless a test opts in by pointing
|
||||
// `ctrl.skillsExtension` at a declaration.
|
||||
getSkillsExtension = vi.fn(() => ctrl.skillsExtension);
|
||||
authenticate = (...a: Parameters<InspectorClient["authenticate"]>) =>
|
||||
clientSpies.authenticate(...a);
|
||||
clearOAuthTokens = (
|
||||
|
|
@ -232,6 +240,11 @@ const h = vi.hoisted(() => {
|
|||
resourceTemplates: ctrl.resourceTemplates,
|
||||
})),
|
||||
useManagedPrompts: vi.fn(() => ({ prompts: ctrl.prompts })),
|
||||
useManagedSkills: vi.fn(() => ({
|
||||
skills: ctrl.skills,
|
||||
pageCount: ctrl.skills.length > 0 ? 1 : 0,
|
||||
error: null,
|
||||
})),
|
||||
useMessageLog: vi.fn(() => ({ messages: ctrl.messages })),
|
||||
useFetchRequestLog: vi.fn(() => ({ fetchRequests: ctrl.fetchRequests })),
|
||||
useStderrLog: vi.fn(() => ({ stderrLogs: ctrl.stderrLogs })),
|
||||
|
|
@ -246,6 +259,7 @@ vi.mock("@inspector/core/mcp/state/index.js", () => ({
|
|||
ManagedResourcesState: h.FakeManager,
|
||||
ManagedResourceTemplatesState: h.FakeManager,
|
||||
ManagedPromptsState: h.FakeManager,
|
||||
ManagedSkillsState: h.FakeManager,
|
||||
MessageLogState: h.FakeManager,
|
||||
FetchRequestLogState: h.FakeManager,
|
||||
StderrLogState: h.FakeManager,
|
||||
|
|
@ -271,6 +285,9 @@ vi.mock("@inspector/core/react/useManagedResources.js", () => ({
|
|||
vi.mock("@inspector/core/react/useManagedResourceTemplates.js", () => ({
|
||||
useManagedResourceTemplates: h.useManagedResourceTemplates,
|
||||
}));
|
||||
vi.mock("@inspector/core/react/useManagedSkills.js", () => ({
|
||||
useManagedSkills: h.useManagedSkills,
|
||||
}));
|
||||
vi.mock("@inspector/core/react/useManagedPrompts.js", () => ({
|
||||
useManagedPrompts: h.useManagedPrompts,
|
||||
}));
|
||||
|
|
@ -664,6 +681,8 @@ beforeEach(() => {
|
|||
resources: [],
|
||||
resourceTemplates: [],
|
||||
prompts: [],
|
||||
skills: [],
|
||||
skillsExtension: undefined as { directoryRead: boolean } | undefined,
|
||||
messages: [],
|
||||
fetchRequests: [],
|
||||
stderrLogs: [],
|
||||
|
|
@ -751,6 +770,42 @@ describe("App (foundation)", () => {
|
|||
expect(h.connect).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("hides the Skills tab until the server declares the extension", async () => {
|
||||
// A *server*-declared extension (SEP-2640), so unlike the transport-derived
|
||||
// tabs it is only knowable after connecting — and showing it against a
|
||||
// server that never declared it would send `skills/list` to a server that
|
||||
// answers -32601 (#2248).
|
||||
h.ctrl.status = "connected";
|
||||
const r = await mount(oneStdio());
|
||||
await expectFrame(r, "Tools");
|
||||
expect(r.lastFrame() ?? "").not.toContain("Skills");
|
||||
});
|
||||
|
||||
it("shows the Skills tab, with its count, once the extension is declared", async () => {
|
||||
h.ctrl.status = "connected";
|
||||
h.ctrl.skillsExtension = { directoryRead: false };
|
||||
h.ctrl.skills = [
|
||||
{
|
||||
uri: "skill://demo/SKILL.md",
|
||||
frontmatter: { name: "demo", description: "d" },
|
||||
resources: [],
|
||||
},
|
||||
];
|
||||
const r = await mount(oneStdio());
|
||||
await expectFrame(r, "Skills (1)");
|
||||
});
|
||||
|
||||
it("opens the Skills tab with its 'k' accelerator", async () => {
|
||||
// `k`, not `s` — the accelerator has to appear in the label and stay
|
||||
// unique; see `tabsConfig.ts`.
|
||||
h.ctrl.status = "connected";
|
||||
h.ctrl.skillsExtension = { directoryRead: true };
|
||||
const r = await mount(oneStdio());
|
||||
await expectFrame(r, "Skills");
|
||||
r.stdin.write("k");
|
||||
await expectFrame(r, "Select a skill to view details");
|
||||
});
|
||||
|
||||
it("disconnects with 'd' when connected", async () => {
|
||||
h.ctrl.status = "connected";
|
||||
const { stdin } = await mount(oneStdio());
|
||||
|
|
|
|||
537
clients/tui/__tests__/SkillsTab.test.tsx
Normal file
537
clients/tui/__tests__/SkillsTab.test.tsx
Normal file
|
|
@ -0,0 +1,537 @@
|
|||
import React from "react";
|
||||
import { describe, it, expect, vi } from "vitest";
|
||||
import { render } from "./helpers/renderTui";
|
||||
import type { InspectorClient } from "@inspector/core/mcp/index.js";
|
||||
import type { SkillEntry } from "@inspector/core/mcp/skillsSchemas.js";
|
||||
import { AuthRecoveryRequiredError } from "@inspector/core/auth/challenge.js";
|
||||
import { sha256Digest, textToBytes } from "@inspector/core/mcp/skills.js";
|
||||
|
||||
// MUST mock ink-scroll-view: the real ScrollView renders a placeholder minimap
|
||||
// in the non-TTY test env and never mounts its children.
|
||||
vi.mock("ink-scroll-view", () => import("./helpers/inkScrollViewMock.js"));
|
||||
|
||||
import { SkillsTab } from "../src/components/SkillsTab.js";
|
||||
|
||||
const tick = async () => {
|
||||
for (let i = 0; i < 8; i++)
|
||||
await new Promise((resolve) => setTimeout(resolve, 4));
|
||||
};
|
||||
|
||||
const ESC = String.fromCharCode(27);
|
||||
const UP = `${ESC}[A`;
|
||||
const DOWN = `${ESC}[B`;
|
||||
const PAGE_UP = `${ESC}[5~`;
|
||||
const PAGE_DOWN = `${ESC}[6~`;
|
||||
const ENTER = "\r";
|
||||
|
||||
const SKILL_MD = "---\nname: clean\ndescription: A clean skill\n---\n\n# C\n";
|
||||
// sha256 of SKILL_MD, so the clean fixture actually verifies.
|
||||
const CLEAN_DIGEST =
|
||||
"sha256:0000000000000000000000000000000000000000000000000000000000000000";
|
||||
|
||||
const clean: SkillEntry = {
|
||||
uri: "skill://clean/SKILL.md",
|
||||
frontmatter: { name: "clean", description: "A clean skill" },
|
||||
resources: [
|
||||
{ uri: "skill://clean/SKILL.md", digest: CLEAN_DIGEST, size: 51 },
|
||||
],
|
||||
};
|
||||
// A `name-path-mismatch`: the one structural invariant SEP-2640 states
|
||||
// outright, so this row must carry the error mark.
|
||||
const broken: SkillEntry = {
|
||||
uri: "skill://wrong-folder/SKILL.md",
|
||||
frontmatter: { name: "right-name", description: "Mismatched" },
|
||||
resources: [
|
||||
{ uri: "skill://wrong-folder/SKILL.md", digest: CLEAN_DIGEST, size: 1 },
|
||||
],
|
||||
};
|
||||
// Legal but unverifiable — a WARNING, which must read differently from an error.
|
||||
const dynamic: SkillEntry = {
|
||||
uri: "skill://gen/SKILL.md",
|
||||
frontmatter: { name: "gen", description: "Generated" },
|
||||
resources: "dynamic",
|
||||
};
|
||||
const noSize: SkillEntry = {
|
||||
uri: "skill://nosize/SKILL.md",
|
||||
frontmatter: { name: "nosize", description: "No declared size" },
|
||||
resources: [{ uri: "skill://nosize/SKILL.md", digest: CLEAN_DIGEST }],
|
||||
};
|
||||
|
||||
const skills = [clean, broken, dynamic, noSize];
|
||||
|
||||
function mockClient(
|
||||
readResource: unknown = vi.fn().mockResolvedValue({
|
||||
result: { contents: [{ uri: "skill://clean/SKILL.md", text: SKILL_MD }] },
|
||||
}),
|
||||
): InspectorClient {
|
||||
return { readResource } as unknown as InspectorClient;
|
||||
}
|
||||
|
||||
describe("SkillsTab (#2248)", () => {
|
||||
it("renders the empty state when there are no skills", () => {
|
||||
const { lastFrame } = render(
|
||||
<SkillsTab
|
||||
skills={[]}
|
||||
pageCount={0}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
/>,
|
||||
);
|
||||
const frame = lastFrame() ?? "";
|
||||
expect(frame).toContain("Skills (0)");
|
||||
expect(frame).toContain("No skills available");
|
||||
expect(frame).toContain("Select a skill to view details");
|
||||
});
|
||||
|
||||
it("shows the page count only when the walk took more than one page", () => {
|
||||
const one = render(
|
||||
<SkillsTab
|
||||
skills={skills}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
/>,
|
||||
);
|
||||
expect(one.lastFrame() ?? "").toContain("Skills (4)");
|
||||
expect(one.lastFrame() ?? "").not.toContain("pages");
|
||||
const many = render(
|
||||
<SkillsTab
|
||||
skills={skills}
|
||||
pageCount={3}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
/>,
|
||||
);
|
||||
expect(many.lastFrame() ?? "").toContain("3 pages");
|
||||
});
|
||||
|
||||
it("renders the list error in place of the list", () => {
|
||||
const { lastFrame } = render(
|
||||
<SkillsTab
|
||||
skills={[]}
|
||||
pageCount={0}
|
||||
loadError={new Error("walk failed")}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
/>,
|
||||
);
|
||||
expect(lastFrame() ?? "").toContain("walk failed");
|
||||
});
|
||||
|
||||
it("marks each row with its static conformance verdict", () => {
|
||||
// The mark is a glyph, not only a colour: this pane is read over ssh, in
|
||||
// tmux and through `script(1)`, where colour may not survive.
|
||||
const { lastFrame } = render(
|
||||
<SkillsTab
|
||||
skills={skills}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
/>,
|
||||
);
|
||||
const frame = lastFrame() ?? "";
|
||||
expect(frame).toContain("✓ clean");
|
||||
// `skillDisplayName` prefers the declared name over the URI segment.
|
||||
expect(frame).toContain("✗ right-name");
|
||||
expect(frame).toContain("! gen");
|
||||
});
|
||||
|
||||
it("shows the selected skill's URI, description, findings and manifest", () => {
|
||||
const { lastFrame } = render(
|
||||
<SkillsTab
|
||||
skills={skills}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
/>,
|
||||
);
|
||||
const frame = lastFrame() ?? "";
|
||||
expect(frame).toContain("skill://clean/SKILL.md");
|
||||
expect(frame).toContain("A clean skill");
|
||||
expect(frame).toContain("Conformance: conforms");
|
||||
expect(frame).toContain("Manifest (1)");
|
||||
expect(frame).toContain("SKILL.md");
|
||||
expect(frame).toContain("(51 B)");
|
||||
expect(frame).toContain("[Enter to verify digests and frontmatter]");
|
||||
});
|
||||
|
||||
it("renders a dynamic skill's manifest as unadvertised rather than empty", async () => {
|
||||
const { lastFrame, stdin } = render(
|
||||
<SkillsTab
|
||||
skills={skills}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
/>,
|
||||
);
|
||||
stdin.write(DOWN);
|
||||
await tick();
|
||||
stdin.write(DOWN);
|
||||
await tick();
|
||||
const frame = lastFrame() ?? "";
|
||||
expect(frame).toContain('"dynamic" — no files advertised');
|
||||
expect(frame).toContain("integrity cannot be verified");
|
||||
});
|
||||
|
||||
it("omits the size caption when the manifest declares none", async () => {
|
||||
const { lastFrame, stdin } = render(
|
||||
<SkillsTab
|
||||
skills={skills}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
/>,
|
||||
);
|
||||
for (let i = 0; i < 3; i++) {
|
||||
stdin.write(DOWN);
|
||||
await tick();
|
||||
}
|
||||
const frame = lastFrame() ?? "";
|
||||
expect(frame).toContain("Manifest (1)");
|
||||
expect(frame).not.toContain(" B)");
|
||||
});
|
||||
|
||||
it("moves selection with the arrow keys and stops at both boundaries", async () => {
|
||||
const { lastFrame, stdin } = render(
|
||||
<SkillsTab
|
||||
skills={skills}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
/>,
|
||||
);
|
||||
stdin.write(UP);
|
||||
await tick();
|
||||
expect(lastFrame() ?? "").toContain("▶ ✓ clean");
|
||||
stdin.write(DOWN);
|
||||
await tick();
|
||||
expect(lastFrame() ?? "").toContain("▶ ✗ right-name");
|
||||
for (let i = 0; i < 5; i++) {
|
||||
stdin.write(DOWN);
|
||||
await tick();
|
||||
}
|
||||
// `nosize` omits a required `size`, so its row carries the error mark too
|
||||
// — the mark tracks the checks, not the position.
|
||||
expect(lastFrame() ?? "").toContain("▶ ✗ nosize");
|
||||
// …and back up from the bottom, which is the other direction of the same
|
||||
// guard: the top boundary above never exercises the move itself.
|
||||
stdin.write(UP);
|
||||
await tick();
|
||||
expect(lastFrame() ?? "").toContain("▶ ! gen");
|
||||
});
|
||||
|
||||
it("scrolls the details pane without moving the selection", async () => {
|
||||
const scrollBy = vi.fn();
|
||||
const { stdin } = render(
|
||||
<SkillsTab
|
||||
skills={skills}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="details"
|
||||
/>,
|
||||
);
|
||||
stdin.write(UP);
|
||||
stdin.write(DOWN);
|
||||
stdin.write(PAGE_UP);
|
||||
stdin.write(PAGE_DOWN);
|
||||
await tick();
|
||||
// Nothing to assert on the mock beyond not crashing and not moving the
|
||||
// selection — the ScrollView handle is stubbed by the shared mock.
|
||||
expect(scrollBy).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("ignores input entirely when a modal is open", async () => {
|
||||
const { lastFrame, stdin } = render(
|
||||
<SkillsTab
|
||||
skills={skills}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
modalOpen
|
||||
/>,
|
||||
);
|
||||
stdin.write(DOWN);
|
||||
await tick();
|
||||
expect(lastFrame() ?? "").toContain("▶ ✓ clean");
|
||||
});
|
||||
|
||||
it("verifies the selected skill on Enter and reports the outcome", async () => {
|
||||
const readResource = vi.fn().mockResolvedValue({
|
||||
result: { contents: [{ uri: "skill://clean/SKILL.md", text: SKILL_MD }] },
|
||||
});
|
||||
const { lastFrame, stdin } = render(
|
||||
<SkillsTab
|
||||
skills={[clean]}
|
||||
pageCount={1}
|
||||
inspectorClient={mockClient(readResource)}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
/>,
|
||||
);
|
||||
stdin.write(ENTER);
|
||||
await tick();
|
||||
expect(readResource).toHaveBeenCalled();
|
||||
const frame = lastFrame() ?? "";
|
||||
// The fixture's advertised digest is all zeroes, so this is a mismatch —
|
||||
// which is the outcome worth showing loudly.
|
||||
expect(frame).toContain("Verification FAILED");
|
||||
expect(frame).toContain("✗ SKILL.md");
|
||||
});
|
||||
|
||||
it("surfaces the frontmatter cross-check after verifying", async () => {
|
||||
const lying: SkillEntry = {
|
||||
...clean,
|
||||
frontmatter: { name: "clean", description: "Something else entirely" },
|
||||
};
|
||||
const { lastFrame, stdin } = render(
|
||||
<SkillsTab
|
||||
skills={[lying]}
|
||||
pageCount={1}
|
||||
inspectorClient={mockClient()}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
/>,
|
||||
);
|
||||
stdin.write(ENTER);
|
||||
await tick();
|
||||
const frame = lastFrame() ?? "";
|
||||
expect(frame).toContain("Frontmatter cross-check:");
|
||||
expect(frame).toContain("Something else entirely");
|
||||
});
|
||||
|
||||
it("reports an ordinary read failure as a failed verdict, not a crash", async () => {
|
||||
// `verifySkills` records a plain read failure per file rather than
|
||||
// throwing, so the pane shows the verdict rather than the error banner.
|
||||
const readResource = vi.fn().mockRejectedValue(new Error("network down"));
|
||||
const { lastFrame, stdin } = render(
|
||||
<SkillsTab
|
||||
skills={[clean]}
|
||||
pageCount={1}
|
||||
inspectorClient={mockClient(readResource)}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
/>,
|
||||
);
|
||||
stdin.write(ENTER);
|
||||
await tick();
|
||||
expect(lastFrame() ?? "").toContain("Verification FAILED");
|
||||
expect(lastFrame() ?? "").toContain("network down");
|
||||
});
|
||||
|
||||
it("hands an auth-recovery error to the callback instead of rendering it", async () => {
|
||||
// The one error `verifySkills` re-throws: the session's authorization
|
||||
// expired, and this callback is how the TUI offers to fix it. Rendered as
|
||||
// a message instead, the user would be told the file could not be read and
|
||||
// given no way to recover.
|
||||
const err = new AuthRecoveryRequiredError(
|
||||
new URL("https://auth.example/authorize"),
|
||||
{ reason: "expired" } as never,
|
||||
);
|
||||
const onAuthRecoveryRequired = vi.fn();
|
||||
const { lastFrame, stdin } = render(
|
||||
<SkillsTab
|
||||
skills={[clean]}
|
||||
pageCount={1}
|
||||
inspectorClient={mockClient(vi.fn().mockRejectedValue(err))}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
onAuthRecoveryRequired={onAuthRecoveryRequired}
|
||||
/>,
|
||||
);
|
||||
stdin.write(ENTER);
|
||||
await tick();
|
||||
expect(onAuthRecoveryRequired).toHaveBeenCalledWith(err);
|
||||
expect(lastFrame() ?? "").not.toContain("Verification FAILED");
|
||||
});
|
||||
|
||||
it("shows the read failure's own reason under the file it happened on", async () => {
|
||||
// A client missing `readResource` entirely fails every read; the walk
|
||||
// records the reason per file rather than aborting, so the diagnosis lands
|
||||
// beside the file it belongs to.
|
||||
const { lastFrame, stdin } = render(
|
||||
<SkillsTab
|
||||
skills={[clean]}
|
||||
pageCount={1}
|
||||
inspectorClient={{} as unknown as InspectorClient}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
/>,
|
||||
);
|
||||
stdin.write(ENTER);
|
||||
await tick();
|
||||
expect(lastFrame() ?? "").toContain("is not a function");
|
||||
});
|
||||
|
||||
it("does nothing on Enter with no connected client", async () => {
|
||||
const { lastFrame, stdin } = render(
|
||||
<SkillsTab
|
||||
skills={[clean]}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
/>,
|
||||
);
|
||||
stdin.write(ENTER);
|
||||
await tick();
|
||||
expect(lastFrame() ?? "").toContain(
|
||||
"[Enter to verify digests and frontmatter]",
|
||||
);
|
||||
});
|
||||
|
||||
it("reports a verified skill and re-verifies on a second Enter", async () => {
|
||||
// The digest is computed from the very bytes the fake read returns, so the
|
||||
// pass is real rather than a constant that happens to match.
|
||||
const digest = await sha256Digest(textToBytes(SKILL_MD));
|
||||
const verifiable: SkillEntry = {
|
||||
...clean,
|
||||
resources: [
|
||||
{
|
||||
uri: "skill://clean/SKILL.md",
|
||||
digest,
|
||||
size: textToBytes(SKILL_MD).byteLength,
|
||||
},
|
||||
],
|
||||
};
|
||||
const readResource = vi.fn().mockResolvedValue({
|
||||
result: { contents: [{ uri: "skill://clean/SKILL.md", text: SKILL_MD }] },
|
||||
});
|
||||
const { lastFrame, stdin } = render(
|
||||
<SkillsTab
|
||||
skills={[verifiable]}
|
||||
pageCount={1}
|
||||
inspectorClient={mockClient(readResource)}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
/>,
|
||||
);
|
||||
stdin.write(ENTER);
|
||||
await tick();
|
||||
expect(lastFrame() ?? "").toContain("Verified — Enter to re-verify");
|
||||
expect(lastFrame() ?? "").toContain("✓ SKILL.md");
|
||||
|
||||
stdin.write(ENTER);
|
||||
await tick();
|
||||
expect(readResource).toHaveBeenCalledTimes(2);
|
||||
});
|
||||
|
||||
it("shows a verifying state and ignores Enter while one is in flight", async () => {
|
||||
// The guard is what stops a held Enter from opening a second walk over the
|
||||
// same manifest on top of the first.
|
||||
let release: ((value: unknown) => void) | undefined;
|
||||
const readResource = vi.fn(
|
||||
() =>
|
||||
new Promise((resolve) => {
|
||||
release = resolve;
|
||||
}),
|
||||
);
|
||||
const { lastFrame, stdin } = render(
|
||||
<SkillsTab
|
||||
skills={[clean]}
|
||||
pageCount={1}
|
||||
inspectorClient={mockClient(readResource)}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
/>,
|
||||
);
|
||||
stdin.write(ENTER);
|
||||
await tick();
|
||||
expect(lastFrame() ?? "").toContain("[Verifying…]");
|
||||
stdin.write(ENTER);
|
||||
await tick();
|
||||
expect(readResource).toHaveBeenCalledTimes(1);
|
||||
release?.({
|
||||
result: { contents: [{ uri: "skill://clean/SKILL.md", text: SKILL_MD }] },
|
||||
});
|
||||
await tick();
|
||||
});
|
||||
|
||||
it("falls back to the whole URI when a manifest entry has no path separator", async () => {
|
||||
const odd: SkillEntry = {
|
||||
uri: "skill://odd/SKILL.md",
|
||||
frontmatter: { name: "odd", description: "d" },
|
||||
resources: [{ uri: "urn:opaque", digest: CLEAN_DIGEST, size: 1 }],
|
||||
};
|
||||
const { lastFrame } = render(
|
||||
<SkillsTab
|
||||
skills={[odd]}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
/>,
|
||||
);
|
||||
expect(lastFrame() ?? "").toContain("urn:opaque");
|
||||
});
|
||||
|
||||
it("keys a row by its index when the entry carries no URI", () => {
|
||||
// A URI-less entry is a `malformed-uri` finding this pane reports, so it
|
||||
// must still render a addressable row rather than colliding React keys.
|
||||
const nameless = {
|
||||
uri: "",
|
||||
frontmatter: { name: "nameless", description: "d" },
|
||||
resources: [],
|
||||
} as SkillEntry;
|
||||
const { lastFrame } = render(
|
||||
<SkillsTab
|
||||
skills={[nameless]}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
/>,
|
||||
);
|
||||
expect(lastFrame() ?? "").toContain("nameless");
|
||||
});
|
||||
|
||||
it("shows the details footer only when the details pane is focused", () => {
|
||||
const unfocused = render(
|
||||
<SkillsTab
|
||||
skills={[clean]}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="list"
|
||||
/>,
|
||||
);
|
||||
expect(unfocused.lastFrame() ?? "").not.toContain("Enter to verify\n");
|
||||
const focused = render(
|
||||
<SkillsTab
|
||||
skills={[clean]}
|
||||
pageCount={1}
|
||||
inspectorClient={null}
|
||||
width={140}
|
||||
height={30}
|
||||
focusedPane="details"
|
||||
/>,
|
||||
);
|
||||
expect(focused.lastFrame() ?? "").toContain(
|
||||
"↑/↓ to scroll, Enter to verify",
|
||||
);
|
||||
});
|
||||
});
|
||||
|
|
@ -50,6 +50,38 @@ describe("Tabs", () => {
|
|||
expect(lastFrame() ?? "").toContain("Network");
|
||||
});
|
||||
|
||||
it("hides the skills tab by default and shows it when showSkills is true", () => {
|
||||
// A *server-declared* extension (SEP-2640), unlike the transport-derived
|
||||
// gates above — it is only knowable after connecting, so the default has
|
||||
// to be hidden.
|
||||
const hidden = render(
|
||||
<Tabs activeTab="info" onTabChange={noop} width={140} />,
|
||||
);
|
||||
expect(hidden.lastFrame() ?? "").not.toContain("Skills");
|
||||
const shown = render(
|
||||
<Tabs
|
||||
activeTab="info"
|
||||
onTabChange={noop}
|
||||
width={140}
|
||||
showSkills={true}
|
||||
/>,
|
||||
);
|
||||
expect(shown.lastFrame() ?? "").toContain("Skills");
|
||||
});
|
||||
|
||||
it("renders a count on the skills tab", () => {
|
||||
const { lastFrame } = render(
|
||||
<Tabs
|
||||
activeTab="skills"
|
||||
onTabChange={noop}
|
||||
width={140}
|
||||
showSkills={true}
|
||||
counts={{ skills: 4 }}
|
||||
/>,
|
||||
);
|
||||
expect(lastFrame() ?? "").toContain("Skills (4)");
|
||||
});
|
||||
|
||||
it("marks the active tab with the ▶ marker", () => {
|
||||
const { lastFrame } = render(
|
||||
<Tabs activeTab="tools" onTabChange={noop} width={120} />,
|
||||
|
|
|
|||
Loading…
Reference in a new issue