fix(web): address review feedback on the monitoring column (#1616)
- ResizeHandle: clear the `resizing-col` body class on unmount so a drag
interrupted by the handle unmounting (narrow past the breakpoint / disconnect)
can't leave page-wide user-select:none / col-resize applied.
- Embedded monitor column now shows the full unfiltered stream instead of
silently mirroring the full-size screen's live filter (the column has no
filter control to explain an empty/partial list).
- MonitoringControls: give the SegmentedControl an aria-label ("Monitoring
screen") so the tab group has an accessible name.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
daf736c6e7
commit
9b76272ad1
1 changed files with 124 additions and 11 deletions
|
|
@ -80,13 +80,16 @@ export function LogStreamPanel({
|
|||
}: LogStreamPanelProps) {
|
||||
const viewportRef = useScrollMemory("logs-stream");
|
||||
const filteredEntries = useMemo(() => {
|
||||
// `.filter()` returns a fresh array, so sorting in-place is safe.
|
||||
// The embedded column has no filter sidebar, so it shows the full stream
|
||||
// rather than mirroring the full-size screen's live filter with no visible
|
||||
// control to explain it (#1616). `.filter()` returns a fresh array, so
|
||||
// sorting in-place is safe.
|
||||
const sorted = entries
|
||||
.filter((e) => matchesFilters(e, filterText, visibleLevels))
|
||||
.filter((e) => embedded || matchesFilters(e, filterText, visibleLevels))
|
||||
.sort((a, b) => a.receivedAt.getTime() - b.receivedAt.getTime());
|
||||
if (sortDirection === "newest-first") sorted.reverse();
|
||||
return sorted;
|
||||
}, [entries, filterText, visibleLevels, sortDirection]);
|
||||
}, [entries, filterText, visibleLevels, sortDirection, embedded]);
|
||||
|
||||
return (
|
||||
<PanelContainer>
|
||||
|
|
|
|||
Loading…
Reference in a new issue