test(web): drop the double casts from the resources hook mock
`as unknown as ReturnType<typeof useManagedResources>` erased the hook's contract and hid that the mock omitted its required `error` and `listChanged` fields, which the repo's TypeScript rules disallow. Build the complete `UseManagedResourcesResult` through a small helper instead, so a future change to that interface fails the typecheck here. Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
a1c00e51a8
commit
9f8dc82a9a
1 changed files with 20 additions and 11 deletions
|
|
@ -615,6 +615,8 @@ import type {
|
||||||
} from "@inspector/core/mcp/types.js";
|
} from "@inspector/core/mcp/types.js";
|
||||||
import type { AppBridgeFactoryDeps } from "./components/elements/AppRenderer/createAppBridgeFactory";
|
import type { AppBridgeFactoryDeps } from "./components/elements/AppRenderer/createAppBridgeFactory";
|
||||||
import { useManagedResources } from "@inspector/core/react/useManagedResources.js";
|
import { useManagedResources } from "@inspector/core/react/useManagedResources.js";
|
||||||
|
import type { UseManagedResourcesResult } from "@inspector/core/react/useManagedResources.js";
|
||||||
|
import type { Resource } from "@modelcontextprotocol/client";
|
||||||
|
|
||||||
// Default useInspectorClient return — capabilities empty (no task tool calls).
|
// Default useInspectorClient return — capabilities empty (no task tool calls).
|
||||||
// Individual tests override via vi.mocked(...).mockReturnValue(...).
|
// Individual tests override via vi.mocked(...).mockReturnValue(...).
|
||||||
|
|
@ -3143,6 +3145,19 @@ describe("App background command rejections (#2049)", () => {
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
/** A complete `useManagedResources` return, so the mock stays type-checked against the hook's contract. */
|
||||||
|
function managedResourcesResult(
|
||||||
|
resources: Resource[],
|
||||||
|
): UseManagedResourcesResult {
|
||||||
|
return {
|
||||||
|
error: null,
|
||||||
|
resources,
|
||||||
|
listChanged: false,
|
||||||
|
refresh: vi.fn().mockResolvedValue(resources),
|
||||||
|
clearListChanged: vi.fn(),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
describe("App MCP App listed-resource metadata wiring (#2055)", () => {
|
describe("App MCP App listed-resource metadata wiring (#2055)", () => {
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
appBridgeFactoryDeps.length = 0;
|
appBridgeFactoryDeps.length = 0;
|
||||||
|
|
@ -3151,11 +3166,7 @@ describe("App MCP App listed-resource metadata wiring (#2055)", () => {
|
||||||
afterEach(() => {
|
afterEach(() => {
|
||||||
// The hook mock is module-level and shared, so put the empty-list default
|
// The hook mock is module-level and shared, so put the empty-list default
|
||||||
// back rather than leaving a populated list for whatever runs next.
|
// back rather than leaving a populated list for whatever runs next.
|
||||||
vi.mocked(useManagedResources).mockReturnValue({
|
vi.mocked(useManagedResources).mockReturnValue(managedResourcesResult([]));
|
||||||
resources: [],
|
|
||||||
refresh: vi.fn(),
|
|
||||||
clearListChanged: vi.fn(),
|
|
||||||
} as unknown as ReturnType<typeof useManagedResources>);
|
|
||||||
});
|
});
|
||||||
|
|
||||||
it("hands the bridge factory a getListedResourceMeta reading the resources/list entries", async () => {
|
it("hands the bridge factory a getListedResourceMeta reading the resources/list entries", async () => {
|
||||||
|
|
@ -3165,13 +3176,11 @@ describe("App MCP App listed-resource metadata wiring (#2055)", () => {
|
||||||
const listedMeta = {
|
const listedMeta = {
|
||||||
ui: { csp: { connectDomains: ["https://api.example.com"] } },
|
ui: { csp: { connectDomains: ["https://api.example.com"] } },
|
||||||
};
|
};
|
||||||
vi.mocked(useManagedResources).mockReturnValue({
|
vi.mocked(useManagedResources).mockReturnValue(
|
||||||
resources: [
|
managedResourcesResult([
|
||||||
{ uri: "ui://weather/app.html", name: "app", _meta: listedMeta },
|
{ uri: "ui://weather/app.html", name: "app", _meta: listedMeta },
|
||||||
],
|
]),
|
||||||
refresh: vi.fn(),
|
);
|
||||||
clearListChanged: vi.fn(),
|
|
||||||
} as unknown as ReturnType<typeof useManagedResources>);
|
|
||||||
|
|
||||||
renderWithMantine(<App />);
|
renderWithMantine(<App />);
|
||||||
await waitFor(() => expect(appBridgeFactoryDeps.length).toBeGreaterThan(0));
|
await waitFor(() => expect(appBridgeFactoryDeps.length).toBeGreaterThan(0));
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue