From 9fd5bc177cb9e40e651756c533fed14526043bc6 Mon Sep 17 00:00:00 2001 From: cliffhall Date: Tue, 11 Aug 2026 23:45:09 -0400 Subject: [PATCH] chore: drop the orphaned root override, and correct the TUI coverage note MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Review follow-ups on #1983 (Copilot's suppressed comments). Removing `ink-form` from the root dependencies left `overrides.ink-select-input` with nothing to override: no root dependency reaches that package any more, and the regenerated lock carries no entry for it. The override that matters lives in `clients/tui/package.json`, where the build resolves `ink-form` — and it is what puts `ink-select-input@6` (rather than the React-18-era v5) into the bundle. The README paragraph above the new bundling section still described the Ink components and `App.tsx` as an interim coverage exclusion. #1501 lifted that: `vitest.config.ts` now gates all of `src/**`, excluding only the pure `src/tui-servers.ts` re-export. Corrected to match the config it describes. Closes #1952 Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_01WLYmVPVLdeYpE6aMTUsCks --- clients/tui/README.md | 14 ++++++++++---- package.json | 3 --- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/clients/tui/README.md b/clients/tui/README.md index 58e8be40..0fb57407 100644 --- a/clients/tui/README.md +++ b/clients/tui/README.md @@ -102,10 +102,16 @@ The repo-root `validate:tui` just delegates here. `eslint.config.js` registers stricter react-hooks@7 rules are not enforced on the interim component surface (#1501). -Tests live in `__tests__/`. The coverage gate currently covers the TUI's -non-React logic (server resolution, logger, tab metadata, and the `utils/` -form/URL helpers); the Ink components and `App.tsx` are an interim exclusion in -`vitest.config.ts` pending a renderer-based follow-up. +Tests live in `__tests__/`. The coverage gate covers **all of `src/**`**, React +surface included — the Ink components mount through `ink-testing-library` (with +the `ink-scroll-view` / `ink-form` passthrough doubles in `__tests__/helpers/`), +`App.tsx` mounts against a mock of the `@inspector/core` surface, and keypresses +are driven through stdin. The former interim exclusion of the components and +`App.tsx` was lifted in #1501; the only exclusion left in `vitest.config.ts` is +`src/tui-servers.ts`, a pure re-export of core's server resolver with no runtime +statements of its own (its logic is measured in `core/` via the web suite, and +`tui-servers.test.ts` still exercises it behaviorally — it is excluded only so it +doesn't surface as a misleading 0/0 row). ### Bundling: React-rendering dependencies must be inlined (#1952) diff --git a/package.json b/package.json index c09afb9d..6484a82f 100644 --- a/package.json +++ b/package.json @@ -99,9 +99,6 @@ "yaml": "^2.9.0", "zod": "^4.4.3" }, - "overrides": { - "ink-select-input": "^6.2.0" - }, "engines": { "node": ">=22.19.0" },