modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: strip ANSI from TUI test frames so FORCE_COLOR cannot break assertions (#2207)

Browse source 
Ink writes styling as escape sequences inside the styled run, so an
accelerator underline splits the word it decorates: `<Text underline>I</Text>nfo`
reaches the frame buffer with escapes between `I` and `nfo`, and a plain
`toContain("Info")` fails against a component that is rendering correctly.
Chalk only emits color when it detects a TTY, so CI stays green and the six
failures land only on a developer whose shell exports FORCE_COLOR.

Add `__tests__/helpers/renderTui.tsx` — ink-testing-library's `render` with
`lastFrame()` and `frames` ANSI-stripped — and point all 16 renderer test
files at it. `frames` is a getter reading through to the live array, since
Ink appends to it as the component re-renders; the raw bytes stay reachable
as `stdout.lastFrame()`.

Pinning FORCE_COLOR=0 would turn the six green while hiding the class: any
future assertion on styled text has the same problem, and the suite would
stop covering the styled path at all.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MFp2LVH7UJST5i8bDBJghw
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-09-06 20:00:15 -04:00
commit a3bb679f1e
1 changed files with 141 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

16
clients/tui/README.md
View file

@ -103,8 +103,10 @@ stricter react-hooks@7 rules are not enforced on the interim component surface
(#1501).
Tests live in `__tests__/`. The coverage gate covers **all of `src/**`**, React
surface included — the Ink components mount through `ink-testing-library` (with
the `ink-scroll-view` / `ink-form` passthrough doubles in `__tests__/helpers/`),
surface included — the Ink components mount through
`__tests__/helpers/renderTui.tsx`, `ink-testing-library`'s `render` wrapped so
every frame it hands back is ANSI-stripped (with the `ink-scroll-view` /
`ink-form` passthrough doubles in the same directory),
`App.tsx` mounts against a mock of the `@inspector/core` surface, and keypresses
are driven through stdin. The former interim exclusion of the components and
`App.tsx` was lifted in #1501; the only exclusion left in `vitest.config.ts` is
@ -113,6 +115,16 @@ statements of its own (its logic is measured in `core/` via the web suite, and
`tui-servers.test.ts` still exercises it behaviorally — it is excluded only so it
doesn't surface as a misleading 0/0 row).
**Import `render` from `__tests__/helpers/renderTui.tsx`, never from
`ink-testing-library` directly.** Ink writes styling as escape sequences *inside*
the styled run, so an accelerator underline splits the word it decorates —
`<Text underline>I</Text>nfo` reaches the frame buffer with escapes between `I`
and `nfo`, and `expect(frame).toContain("Info")` fails against a component that
is rendering correctly. Because chalk only emits color when it detects a TTY,
this is invisible in CI and hits exactly the developer whose shell exports
`FORCE_COLOR` (#2207). The wrapper strips styling from `lastFrame()` and
`frames`; the untouched bytes stay available as `stdout.lastFrame()`.
### Bundling: React-rendering dependencies must be inlined (#1952)
`tsup.config.ts` splits the TUI's dependencies into bundled (`noExternal`) and