From a3be456f562ac9978be5b95f4fa973cf607df864 Mon Sep 17 00:00:00 2001
From: cliffhall <cliff@futurescale.com>
Date: Tue, 21 Apr 2026 18:13:40 -0400
Subject: [PATCH] Remove unused fn() from ServerSettingsForm stories
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The Storybook config has no addon-actions/addon-essentials, so fn()
calls never produce visible output. The stories are fully interactive
via useState — add/remove/edit headers, metadata, timeouts, OAuth,
and connection mode all work visually in the UI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../ServerSettingsForm.stories.tsx            | 68 +++++++------------
 1 file changed, 24 insertions(+), 44 deletions(-)

diff --git a/clients/web/src/components/groups/ServerSettingsForm/ServerSettingsForm.stories.tsx b/clients/web/src/components/groups/ServerSettingsForm/ServerSettingsForm.stories.tsx
index dd568f29..d32473f1 100644
--- a/clients/web/src/components/groups/ServerSettingsForm/ServerSettingsForm.stories.tsx
+++ b/clients/web/src/components/groups/ServerSettingsForm/ServerSettingsForm.stories.tsx
@@ -1,7 +1,6 @@
 import { useState } from "react";
 import type { InspectorServerSettings } from "@inspector/core/mcp/types.js";
 import type { Meta, StoryObj } from "@storybook/react-vite";
-import { fn } from "storybook/test";
 import {
   ServerSettingsForm,
   type ServerSettingsSection,
@@ -15,16 +14,6 @@ const defaultSettings: InspectorServerSettings = {
   requestTimeout: 60000,
 };
 
-const onConnectionModeChange = fn();
-const onAddHeader = fn();
-const onRemoveHeader = fn();
-const onHeaderChange = fn();
-const onAddMetadata = fn();
-const onRemoveMetadata = fn();
-const onMetadataChange = fn();
-const onTimeoutChange = fn();
-const onOAuthChange = fn();
-
 function InteractiveForm({
   startSettings,
   initialSections = ["connectionMode"],
@@ -42,58 +31,50 @@ function InteractiveForm({
       settings={settings}
       expandedSections={expandedSections}
       onExpandedSectionsChange={setExpandedSections}
-      onConnectionModeChange={(mode) => {
-        setSettings((s) => ({ ...s, connectionMode: mode }));
-        onConnectionModeChange(mode);
-      }}
-      onAddHeader={() => {
+      onConnectionModeChange={(mode) =>
+        setSettings((s) => ({ ...s, connectionMode: mode }))
+      }
+      onAddHeader={() =>
         setSettings((s) => ({
           ...s,
           headers: [...s.headers, { key: "", value: "" }],
-        }));
-        onAddHeader();
-      }}
-      onRemoveHeader={(index) => {
+        }))
+      }
+      onRemoveHeader={(index) =>
         setSettings((s) => ({
           ...s,
           headers: s.headers.filter((_, i) => i !== index),
-        }));
-        onRemoveHeader(index);
-      }}
-      onHeaderChange={(index, key, value) => {
+        }))
+      }
+      onHeaderChange={(index, key, value) =>
         setSettings((s) => ({
           ...s,
           headers: s.headers.map((h, i) => (i === index ? { key, value } : h)),
-        }));
-        onHeaderChange(index, key, value);
-      }}
-      onAddMetadata={() => {
+        }))
+      }
+      onAddMetadata={() =>
         setSettings((s) => ({
           ...s,
           metadata: [...s.metadata, { key: "", value: "" }],
-        }));
-        onAddMetadata();
-      }}
-      onRemoveMetadata={(index) => {
+        }))
+      }
+      onRemoveMetadata={(index) =>
         setSettings((s) => ({
           ...s,
           metadata: s.metadata.filter((_, i) => i !== index),
-        }));
-        onRemoveMetadata(index);
-      }}
-      onMetadataChange={(index, key, value) => {
+        }))
+      }
+      onMetadataChange={(index, key, value) =>
         setSettings((s) => ({
           ...s,
           metadata: s.metadata.map((m, i) =>
             i === index ? { key, value } : m,
           ),
-        }));
-        onMetadataChange(index, key, value);
-      }}
-      onTimeoutChange={(field, value) => {
-        setSettings((s) => ({ ...s, [field]: value }));
-        onTimeoutChange(field, value);
-      }}
+        }))
+      }
+      onTimeoutChange={(field, value) =>
+        setSettings((s) => ({ ...s, [field]: value }))
+      }
       onOAuthChange={(field, value) => {
         const fieldMap: Record<string, string> = {
           clientId: "oauthClientId",
@@ -101,7 +82,6 @@ function InteractiveForm({
           scopes: "oauthScopes",
         };
         setSettings((s) => ({ ...s, [fieldMap[field] ?? field]: value }));
-        onOAuthChange(field, value);
       }}
     />
   );