modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: the classifier does not survive structuredClone, and the test now proves it

Browse source 
Since round 1 the doc claimed the `name` fallback covers "a structured clone or
a JSON hop". Verified, and it is false for half of that:

  structuredClone(new InsecureTokenEndpointError(url))
    -> name: "Error", tokenEndpoint: undefined, constructor: Error

structuredClone normalizes a custom Error subclass back to Error, so neither
arm has anything left to match. A caller routing this error through
structuredClone or postMessage would silently get the generic retryable
handling back — the exact defect this PR removes.

The test could not have caught it: it hand-built a look-alike plain object, so
it asserted what I believed the boundary does rather than what it does. It now
performs a real JSON round trip (asserting the prototype is gone), and a second
case pins that structuredClone is NOT recognized — turning a false claim into a
tested limitation.

The doc comment now scopes the contract to JSON and states the structuredClone
limit with the remedy: serialize the fields explicitly across such a boundary.

Also removes an orphaned JSDoc block the round-4 refactor stranded above the
report helper, and gives showInsecureTokenEndpointNotice its own doc back.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018MvNbmAtQuWhDvzi4yXDju
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-09-07 11:16:51 -04:00
commit a5a9d4fe15
1 changed files with 52 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

16
core/auth/insecureTokenEndpoint.ts
View file

@ -36,10 +36,18 @@ export interface InsecureTokenEndpointShape {
* on an instance — don't check that property.)
*
* The `name` comparison is the same deliberate serialization fallback
* `isAuthorizationServerMismatchShape` carries in `issuerBinding.ts`: today the
* web client runs `auth()` in the browser, so no boundary is crossed, but the
* prototype and brand set are the first things a structured clone or a JSON hop
* would drop, and `name` survives both.
* `isAuthorizationServerMismatchShape` carries in `issuerBinding.ts`. Today the
* web client runs `auth()` in the browser so no boundary is crossed, but a JSON
* hop drops the prototype and the brand set while preserving `name` and
* `tokenEndpoint`, and that is the case this arm exists for.
*
* ⚠️ **It does not cover `structuredClone`, and cannot.** That algorithm
* normalizes a custom `Error` subclass back to `Error` — `name` becomes
* `"Error"` and own properties like `tokenEndpoint` are dropped entirely — so
* nothing survives for either arm to match on. A caller who routes this error
* through `structuredClone` (or `postMessage`, which uses it) will silently get
* the generic retryable handling back. Serialize the fields explicitly across
* such a boundary rather than relying on this classifier.
*/
function isInsecureTokenEndpointShape(
err: unknown,