modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: address Copilot review round 11 — recurse constants into nested objects

Browse source 
applySchemaConstants only corrected top-level pinned fields, but the deep
link's overlay replaces a nested object wholesale rather than merging into it —
so `{ config: { kind: "sms" } }` slipped past a nested read-only
`kind: { const: "email" }` the form was displaying. It now recurses into
object-valued properties, resolving each one's own root union the same way.

Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-08-26 04:36:13 -04:00
commit a69cb58451
1 changed files with 49 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

36
clients/web/src/utils/jsonUtils.ts
View file

@ -194,14 +194,34 @@ export function applySchemaConstants(
const { base, branches } = resolveRootUnion(schema);
const selected = selectBranchIndex(branches, values) ?? 0;
const properties = (branches[selected]?.schema ?? base).properties ?? {};
const pinned = Object.entries(properties).filter(
([, fieldSchema]) => fieldSchema.const !== undefined,
);
if (pinned.length === 0) return values;
return Object.fromEntries([
...Object.entries(values),
...pinned.map(([name, fieldSchema]) => [name, fieldSchema.const]),
]);
const corrections: [string, unknown][] = [];
for (const [name, rawSchema] of Object.entries(properties)) {
const fieldSchema = normalizeNullableUnion(rawSchema);
if (fieldSchema.const !== undefined) {
corrections.push([name, fieldSchema.const]);
continue;
}
// Recurse: a nested object renders its own read-only fields, and the
// overlay replaces the whole object rather than merging into it — so a
// link naming `{ config: { kind: "sms" } }` would otherwise slip a value
// past the pinned `kind` the nested form is displaying.
const nested = values[name];
if (
typeof nested === "object" &&
nested !== null &&
!Array.isArray(nested)
) {
const corrected = applySchemaConstants(
fieldSchema,
nested as Record<string, unknown>,
);
if (corrected !== nested) corrections.push([name, corrected]);
}
}
if (corrections.length === 0) return values;
return Object.fromEntries([...Object.entries(values), ...corrections]);
}
/**