Add ServerSettingsModal group, revert form to controlled component

Revert ServerSettingsForm to a controlled component with
expandedSections/onExpandedSectionsChange props. The form is a
dumb component — accordion state belongs to its container.

Create ServerSettingsModal group that manages:
- Accordion expand/collapse state with ListToggle expand-all button
- Add/remove/edit header pairs
- Add/remove/edit metadata pairs
- Connection mode, timeout, and OAuth changes
- All changes flow through a single onSettingsChange callback

Update ServerSettingsForm stories with useState render functions
so accordion sections are interactive.

Update UnconnectedView WithSettingsModal story to use the new
ServerSettingsModal component.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
cliffhall 2026-04-21 17:13:57 -04:00
commit a6fc900271
2 changed files with 307 additions and 100 deletions

View file

@ -0,0 +1,62 @@
import { useState } from "react";
import type { InspectorServerSettings } from "@inspector/core/mcp/types.js";
import type { Meta, StoryObj } from "@storybook/react-vite";
import { ServerSettingsModal } from "./ServerSettingsModal";
const initialSettings: InspectorServerSettings = {
connectionMode: "proxy",
headers: [
{ key: "Authorization", value: "Bearer token-abc-123" },
{ key: "X-Request-Id", value: "req-456" },
],
metadata: [{ key: "userId", value: "user-789" }],
connectionTimeout: 30000,
requestTimeout: 60000,
oauthClientId: "my-client-id",
oauthClientSecret: "super-secret-value",
oauthScopes: "read write",
};
function InteractiveModal({
startSettings,
}: {
startSettings: InspectorServerSettings;
}) {
const [settings, setSettings] =
useState<InspectorServerSettings>(startSettings);
return (
<ServerSettingsModal
opened
settings={settings}
onClose={() => {}}
onSettingsChange={setSettings}
/>
);
}
const meta: Meta<typeof ServerSettingsModal> = {
title: "Groups/ServerSettingsModal",
component: ServerSettingsModal,
};
export default meta;
type Story = StoryObj<typeof ServerSettingsModal>;
export const FullyConfigured: Story = {
render: () => <InteractiveModal startSettings={initialSettings} />,
};
export const EmptySettings: Story = {
render: () => (
<InteractiveModal
startSettings={{
connectionMode: "proxy",
headers: [],
metadata: [],
connectionTimeout: 30000,
requestTimeout: 60000,
}}
/>
),
};

View file

@ -0,0 +1,139 @@
import { useState } from "react";
import { CloseButton, Group, Modal, Title } from "@mantine/core";
import type { InspectorServerSettings } from "@inspector/core/mcp/types.js";
import { ListToggle } from "../../elements/ListToggle/ListToggle";
import {
ServerSettingsForm,
type ServerSettingsSection,
} from "../ServerSettingsForm/ServerSettingsForm";
const ALL_SECTIONS: ServerSettingsSection[] = [
"connectionMode",
"headers",
"metadata",
"timeouts",
"oauth",
];
export interface ServerSettingsModalProps {
opened: boolean;
settings: InspectorServerSettings;
onClose: () => void;
onSettingsChange: (settings: InspectorServerSettings) => void;
}
export function ServerSettingsModal({
opened,
settings,
onClose,
onSettingsChange,
}: ServerSettingsModalProps) {
const [expandedSections, setExpandedSections] = useState<
ServerSettingsSection[]
>(["connectionMode"]);
const allExpanded = expandedSections.length === ALL_SECTIONS.length;
function handleToggleAll() {
setExpandedSections(allExpanded ? [] : ALL_SECTIONS);
}
function handleConnectionModeChange(mode: "proxy" | "direct") {
onSettingsChange({ ...settings, connectionMode: mode });
}
function handleAddHeader() {
onSettingsChange({
...settings,
headers: [...settings.headers, { key: "", value: "" }],
});
}
function handleRemoveHeader(index: number) {
onSettingsChange({
...settings,
headers: settings.headers.filter((_, i) => i !== index),
});
}
function handleHeaderChange(index: number, key: string, value: string) {
const headers = settings.headers.map((h, i) =>
i === index ? { key, value } : h,
);
onSettingsChange({ ...settings, headers });
}
function handleAddMetadata() {
onSettingsChange({
...settings,
metadata: [...settings.metadata, { key: "", value: "" }],
});
}
function handleRemoveMetadata(index: number) {
onSettingsChange({
...settings,
metadata: settings.metadata.filter((_, i) => i !== index),
});
}
function handleMetadataChange(index: number, key: string, value: string) {
const metadata = settings.metadata.map((m, i) =>
i === index ? { key, value } : m,
);
onSettingsChange({ ...settings, metadata });
}
function handleTimeoutChange(field: string, value: number) {
onSettingsChange({ ...settings, [field]: value });
}
function handleOAuthChange(field: string, value: string) {
const oauthFieldMap: Record<string, string> = {
clientId: "oauthClientId",
clientSecret: "oauthClientSecret",
scopes: "oauthScopes",
};
const settingsKey = oauthFieldMap[field] ?? field;
onSettingsChange({ ...settings, [settingsKey]: value });
}
return (
<Modal
opened={opened}
onClose={onClose}
withCloseButton={false}
title={
<Group justify="space-between" wrap="nowrap" w="100%">
<ListToggle
compact={allExpanded}
variant="subtle"
onToggle={handleToggleAll}
/>
<Title order={4} ta="center" style={{ flex: 1 }}>
Server Settings
</Title>
<CloseButton onClick={onClose} />
</Group>
}
size="lg"
centered
styles={{ title: { flex: 1 } }}
>
<ServerSettingsForm
settings={settings}
expandedSections={expandedSections}
onExpandedSectionsChange={setExpandedSections}
onConnectionModeChange={handleConnectionModeChange}
onAddHeader={handleAddHeader}
onRemoveHeader={handleRemoveHeader}
onHeaderChange={handleHeaderChange}
onAddMetadata={handleAddMetadata}
onRemoveMetadata={handleRemoveMetadata}
onMetadataChange={handleMetadataChange}
onTimeoutChange={handleTimeoutChange}
onOAuthChange={handleOAuthChange}
/>
</Modal>
);
}